fix: handle Z timezone in ISO8601 datetime format (#228)

* fix: handle Z timezone in ISO8601 datetime format

Fixes #226

Author: jooola

hcloud/_compat.py

@@ -0,0 +1,11 @@
+from datetime import datetime
+
+
+def isoparse(value: str) -> datetime:
+    # Python <3.11 doesn't fully support parsing ISO8601 datetime strings. This
+    # workaround replaces the ending `Z` or `z` with `+00:00` and allows
+    # `datetime.fromisoformat` to parse the datetime string.
+    if value[-1] in "Zz":
+        value = value[:-1] + "+00:00"
+
+    return datetime.fromisoformat(value)

hcloud/actions/domain.py

@@ -1,5 +1,4 @@
-from datetime import datetime
-
+from .._compat import isoparse
 from .._exceptions import HCloudException
 from ..core.domain import BaseDomain
 
@@ -51,8 +50,8 @@ def __init__(
 
         self.status = status
         self.progress = progress
-        self.started = datetime.fromisoformat(started) if started else None
-        self.finished = datetime.fromisoformat(finished) if finished else None
+        self.started = isoparse(started) if started else None
+        self.finished = isoparse(finished) if finished else None
         self.resources = resources
         self.error = error
 

hcloud/certificates/domain.py

@@ -1,5 +1,4 @@
-from datetime import datetime
-
+from .._compat import isoparse
 from ..core.domain import BaseDomain, DomainIdentityMixin
 
 
@@ -59,13 +58,9 @@ def __init__(
         self.certificate = certificate
         self.domain_names = domain_names
         self.fingerprint = fingerprint
-        self.not_valid_before = (
-            datetime.fromisoformat(not_valid_before) if not_valid_before else None
-        )
-        self.not_valid_after = (
-            datetime.fromisoformat(not_valid_after) if not_valid_after else None
-        )
-        self.created = datetime.fromisoformat(created) if created else None
+        self.not_valid_before = isoparse(not_valid_before) if not_valid_before else None
+        self.not_valid_after = isoparse(not_valid_after) if not_valid_after else None
+        self.created = isoparse(created) if created else None
         self.labels = labels
         self.status = status
 

hcloud/deprecation/domain.py

@@ -1,5 +1,4 @@
-from datetime import datetime
-
+from .._compat import isoparse
 from ..core.domain import BaseDomain
 
 
@@ -25,7 +24,7 @@ def __init__(
         announced=None,
         unavailable_after=None,
     ):
-        self.announced = datetime.fromisoformat(announced) if announced else None
+        self.announced = isoparse(announced) if announced else None
         self.unavailable_after = (
-            datetime.fromisoformat(unavailable_after) if unavailable_after else None
+            isoparse(unavailable_after) if unavailable_after else None
         )

hcloud/firewalls/domain.py

@@ -1,5 +1,4 @@
-from datetime import datetime
-
+from .._compat import isoparse
 from ..core.domain import BaseDomain
 
 
@@ -30,7 +29,7 @@ def __init__(
         self.rules = rules
         self.applied_to = applied_to
         self.labels = labels
-        self.created = datetime.fromisoformat(created) if created else None
+        self.created = isoparse(created) if created else None
 
 
 class FirewallRule:

hcloud/floating_ips/domain.py

@@ -1,5 +1,4 @@
-from datetime import datetime
-
+from .._compat import isoparse
 from ..core.domain import BaseDomain
 
 
@@ -72,7 +71,7 @@ def __init__(
         self.blocked = blocked
         self.protection = protection
         self.labels = labels
-        self.created = datetime.fromisoformat(created) if created else None
+        self.created = isoparse(created) if created else None
         self.name = name
 
 

hcloud/images/domain.py

@@ -1,5 +1,4 @@
-from datetime import datetime
-
+from .._compat import isoparse
 from ..core.domain import BaseDomain, DomainIdentityMixin
 
 
@@ -85,11 +84,11 @@ def __init__(
         self.id = id
         self.name = name
         self.type = type
-        self.created = datetime.fromisoformat(created) if created else None
+        self.created = isoparse(created) if created else None
         self.description = description
         self.image_size = image_size
         self.disk_size = disk_size
-        self.deprecated = datetime.fromisoformat(deprecated) if deprecated else None
+        self.deprecated = isoparse(deprecated) if deprecated else None
         self.bound_to = bound_to
         self.os_flavor = os_flavor
         self.os_version = os_version

hcloud/isos/domain.py

@@ -1,5 +1,4 @@
-from datetime import datetime
-
+from .._compat import isoparse
 from ..core.domain import BaseDomain, DomainIdentityMixin
 
 
@@ -36,4 +35,4 @@ def __init__(
         self.type = type
         self.architecture = architecture
         self.description = description
-        self.deprecated = datetime.fromisoformat(deprecated) if deprecated else None
+        self.deprecated = isoparse(deprecated) if deprecated else None

hcloud/load_balancers/domain.py

@@ -1,5 +1,4 @@
-from datetime import datetime
-
+from .._compat import isoparse
 from ..core.domain import BaseDomain
 
 
@@ -76,7 +75,7 @@ def __init__(
     ):
         self.id = id
         self.name = name
-        self.created = datetime.fromisoformat(created) if created else None
+        self.created = isoparse(created) if created else None
         self.public_net = public_net
         self.private_net = private_net
         self.location = location

hcloud/networks/domain.py

@@ -1,5 +1,4 @@
-from datetime import datetime
-
+from .._compat import isoparse
 from ..core.domain import BaseDomain
 
 
@@ -54,7 +53,7 @@ def __init__(
     ):
         self.id = id
         self.name = name
-        self.created = datetime.fromisoformat(created) if created else None
+        self.created = isoparse(created) if created else None
         self.ip_range = ip_range
         self.subnets = subnets
         self.routes = routes