Skip to content

Commit 6497688

Browse files
committed
fix: source_ips property is optional in firewall rule
1 parent 63fe718 commit 6497688

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

hcloud/firewalls/domain.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,15 +97,15 @@ def __init__(
9797
self,
9898
direction: str,
9999
protocol: str,
100-
source_ips: list[str],
100+
source_ips: list[str] | None = None,
101101
port: str | None = None,
102102
destination_ips: list[str] | None = None,
103103
description: str | None = None,
104104
):
105105
self.direction = direction
106106
self.port = port
107107
self.protocol = protocol
108-
self.source_ips = source_ips
108+
self.source_ips = source_ips or []
109109
self.destination_ips = destination_ips or []
110110
self.description = description
111111

@@ -116,8 +116,9 @@ def to_payload(self) -> dict[str, Any]:
116116
payload: dict[str, Any] = {
117117
"direction": self.direction,
118118
"protocol": self.protocol,
119-
"source_ips": self.source_ips,
120119
}
120+
if len(self.source_ips) > 0:
121+
payload["source_ips"] = self.source_ips
121122
if len(self.destination_ips) > 0:
122123
payload["destination_ips"] = self.destination_ips
123124
if self.port is not None:

0 commit comments

Comments
 (0)