fix: adjust label validation for max length of 63 characters (#194)

Related to hetznercloud/hcloud-go#273

Author: jooola

hcloud/helpers/labels.py

@@ -4,10 +4,10 @@
 
 class LabelValidator:
     KEY_REGEX = re.compile(
-        "^([a-z0-9A-Z]((?:[\-_.]|[a-z0-9A-Z]){0,253}[a-z0-9A-Z])?/)?[a-z0-9A-Z]((?:[\-_.]|[a-z0-9A-Z]|){0,62}[a-z0-9A-Z])?$"
+        "^([a-z0-9A-Z]((?:[\-_.]|[a-z0-9A-Z]){0,253}[a-z0-9A-Z])?/)?[a-z0-9A-Z]((?:[\-_.]|[a-z0-9A-Z]|){0,61}[a-z0-9A-Z])?$"
     )
     VALUE_REGEX = re.compile(
-        "^(([a-z0-9A-Z](?:[\-_.]|[a-z0-9A-Z]){0,62})?[a-z0-9A-Z]$|$)"
+        "^(([a-z0-9A-Z](?:[\-_.]|[a-z0-9A-Z]){0,61})?[a-z0-9A-Z]$|$)"
     )
 
     @staticmethod

tests/unit/helpers/test_labels.py

@@ -22,6 +22,12 @@
             },
             False,
         ),
+        (
+            {
+                "valid_key": "63-characters-are-allowed-in-a-label__this-is-one-character-more",
+            },
+            False,
+        ),
         # invalid keys
         ({"incorrect.de/": "correct.de"}, False),
         ({"incor rect.de/": "correct.de"}, False),
@@ -75,6 +81,13 @@ def test_validate(labels, expected):
             False,
             "value",
         ),
+        (
+            {
+                "valid_key": "63-characters-are-allowed-in-a-label__this-is-one-character-more",
+            },
+            False,
+            "value",
+        ),
         # invalid keys
         ({"incorrect.de/": "correct.de"}, False, "key"),
         ({"incor rect.de/": "correct.de"}, False, "key"),