refactor: pass list function to _get_first_by helper

This will be useful for coming Storage Box sub resources, which may use different list functions.

Author: jooola

hcloud/certificates/client.py

@@ -202,7 +202,7 @@ def get_by_name(self, name: str) -> BoundCertificate | None:
                Used to get certificate by name.
         :return: :class:`BoundCertificate <hcloud.certificates.client.BoundCertificate>`
         """
-        return self._get_first_by(name=name)
+        return self._get_first_by(self.get_list, name=name)
 
     def create(
         self,

hcloud/core/client.py

@@ -46,10 +46,8 @@ def _iter_pages(  # type: ignore[no-untyped-def]
 
         return results
 
-    def _get_first_by(self, **kwargs):  # type: ignore[no-untyped-def]
-        assert hasattr(self, "get_list")
-        # pylint: disable=no-member
-        entities, _ = self.get_list(**kwargs)
+    def _get_first_by(self, list_function: Callable, *args, **kwargs):  # type: ignore[no-untyped-def]
+        entities, _ = list_function(*args, **kwargs)
         return entities[0] if entities else None
 
 

hcloud/datacenters/client.py

@@ -115,4 +115,4 @@ def get_by_name(self, name: str) -> BoundDatacenter | None:
                Used to get datacenter by name.
         :return: :class:`BoundDatacenter <hcloud.datacenters.client.BoundDatacenter>`
         """
-        return self._get_first_by(name=name)
+        return self._get_first_by(self.get_list, name=name)

hcloud/firewalls/client.py

@@ -351,7 +351,7 @@ def get_by_name(self, name: str) -> BoundFirewall | None:
                Used to get Firewall by name.
         :return: :class:`BoundFirewall <hcloud.firewalls.client.BoundFirewall>`
         """
-        return self._get_first_by(name=name)
+        return self._get_first_by(self.get_list, name=name)
 
     def create(
         self,

hcloud/floating_ips/client.py

@@ -293,7 +293,7 @@ def get_by_name(self, name: str) -> BoundFloatingIP | None:
                Used to get Floating IP by name.
         :return: :class:`BoundFloatingIP <hcloud.floating_ips.client.BoundFloatingIP>`
         """
-        return self._get_first_by(name=name)
+        return self._get_first_by(self.get_list, name=name)
 
     def create(
         self,

hcloud/images/client.py

@@ -329,7 +329,7 @@ def get_by_name(self, name: str) -> BoundImage | None:
             DeprecationWarning,
             stacklevel=2,
         )
-        return self._get_first_by(name=name)
+        return self._get_first_by(self.get_list, name=name)
 
     def get_by_name_and_architecture(
         self,
@@ -349,6 +349,7 @@ def get_by_name_and_architecture(
         :return: :class:`BoundImage <hcloud.images.client.BoundImage>`
         """
         return self._get_first_by(
+            self.get_list,
             name=name,
             architecture=[architecture],
             include_deprecated=include_deprecated,

hcloud/isos/client.py

@@ -99,4 +99,4 @@ def get_by_name(self, name: str) -> BoundIso | None:
                Used to get iso by name.
         :return: :class:`BoundIso <hcloud.isos.client.BoundIso>`
         """
-        return self._get_first_by(name=name)
+        return self._get_first_by(self.get_list, name=name)

hcloud/load_balancer_types/client.py

@@ -81,4 +81,4 @@ def get_by_name(self, name: str) -> BoundLoadBalancerType | None:
                Used to get Load Balancer type by name.
         :return: :class:`BoundLoadBalancerType <hcloud.load_balancer_types.client.BoundLoadBalancerType>`
         """
-        return self._get_first_by(name=name)
+        return self._get_first_by(self.get_list, name=name)

hcloud/load_balancers/client.py

@@ -467,7 +467,7 @@ def get_by_name(self, name: str) -> BoundLoadBalancer | None:
                Used to get Load Balancer by name.
         :return: :class:`BoundLoadBalancer <hcloud.load_balancers.client.BoundLoadBalancer>`
         """
-        return self._get_first_by(name=name)
+        return self._get_first_by(self.get_list, name=name)
 
     def create(
         self,

hcloud/locations/client.py

@@ -76,4 +76,4 @@ def get_by_name(self, name: str) -> BoundLocation | None:
                Used to get location by name.
         :return: :class:`BoundLocation <hcloud.locations.client.BoundLocation>`
         """
-        return self._get_first_by(name=name)
+        return self._get_first_by(self.get_list, name=name)