rename to ResourceClientBase

jooola · jooola · commit 014ccd3047eb · 2025-08-14T14:39:19.000+02:00
diff --git a/hcloud/actions/client.py b/hcloud/actions/client.py
@@ -4,7 +4,7 @@
 import warnings
 from typing import TYPE_CHECKING, Any, NamedTuple
 
-from ..core import BaseResourceClient, BoundModelBase, Meta
+from ..core import BoundModelBase, Meta, ResourceClientBase
 from .domain import Action, ActionFailedException, ActionTimeoutException
 
 if TYPE_CHECKING:
@@ -50,7 +50,7 @@ class ActionsPageResult(NamedTuple):
     meta: Meta
 
 
-class ResourceActionsClient(BaseResourceClient):
+class ResourceActionsClient(ResourceClientBase):
     _resource: str
 
     def __init__(self, client: Client, resource: str | None):
diff --git a/hcloud/certificates/client.py b/hcloud/certificates/client.py
@@ -3,7 +3,7 @@
 from typing import TYPE_CHECKING, Any, NamedTuple
 
 from ..actions import ActionsPageResult, BoundAction, ResourceActionsClient
-from ..core import BaseResourceClient, BoundModelBase, Meta
+from ..core import BoundModelBase, Meta, ResourceClientBase
 from .domain import (
     Certificate,
     CreateManagedCertificateResponse,
@@ -103,7 +103,7 @@ class CertificatesPageResult(NamedTuple):
     meta: Meta
 
 
-class CertificatesClient(BaseResourceClient):
+class CertificatesClient(ResourceClientBase):
     _client: Client
 
     actions: ResourceActionsClient
diff --git a/hcloud/core/__init__.py b/hcloud/core/__init__.py
@@ -1,11 +1,11 @@
 from __future__ import annotations
 
-from .client import BaseResourceClient, BoundModelBase, ClientEntityBase
+from .client import BoundModelBase, ClientEntityBase, ResourceClientBase
 from .domain import BaseDomain, DomainIdentityMixin, Meta, Pagination
 
 __all__ = [
     "BaseDomain",
-    "BaseResourceClient",
+    "ResourceClientBase",
     "BoundModelBase",
     "ClientEntityBase",
     "DomainIdentityMixin",
diff --git a/hcloud/core/client.py b/hcloud/core/client.py
@@ -7,7 +7,7 @@
     from .._client import Client
 
 
-class BaseResourceClient:
+class ResourceClientBase:
     _client: Client
 
     max_per_page: int = 50
@@ -51,18 +51,18 @@ def _get_first_by(self, **kwargs):  # type: ignore[no-untyped-def]
         return entities[0] if entities else None
 
 
-class ClientEntityBase(BaseResourceClient):
+class ClientEntityBase(ResourceClientBase):
     """
     Kept for backward compatibility.
 
     .. deprecated:: 2.6.0
-        Use :class:``hcloud.core.client.BaseResourceClient`` instead.
+        Use :class:``hcloud.core.client.ResourceClientBase`` instead.
     """
 
     def __init__(self, client: Client):
         warnings.warn(
             "The 'hcloud.core.client.ClientEntityBase' class is deprecated, please use the "
-            "'hcloud.core.client.BaseResourceClient' class instead.",
+            "'hcloud.core.client.ResourceClientBase' class instead.",
             DeprecationWarning,
             stacklevel=2,
         )
@@ -76,7 +76,7 @@ class BoundModelBase:
 
     def __init__(
         self,
-        client: BaseResourceClient,
+        client: ResourceClientBase,
         data: dict,
         complete: bool = True,
     ):
diff --git a/hcloud/datacenters/client.py b/hcloud/datacenters/client.py
@@ -2,7 +2,7 @@
 
 from typing import TYPE_CHECKING, Any, NamedTuple
 
-from ..core import BaseResourceClient, BoundModelBase, Meta
+from ..core import BoundModelBase, Meta, ResourceClientBase
 from ..locations import BoundLocation
 from ..server_types import BoundServerType
 from .domain import Datacenter, DatacenterServerTypes
@@ -55,7 +55,7 @@ class DatacentersPageResult(NamedTuple):
     meta: Meta
 
 
-class DatacentersClient(BaseResourceClient):
+class DatacentersClient(ResourceClientBase):
     _client: Client
 
     def get_by_id(self, id: int) -> BoundDatacenter:
diff --git a/hcloud/firewalls/client.py b/hcloud/firewalls/client.py
@@ -3,7 +3,7 @@
 from typing import TYPE_CHECKING, Any, NamedTuple
 
 from ..actions import ActionsPageResult, BoundAction, ResourceActionsClient
-from ..core import BaseResourceClient, BoundModelBase, Meta
+from ..core import BoundModelBase, Meta, ResourceClientBase
 from .domain import (
     CreateFirewallResponse,
     Firewall,
@@ -183,7 +183,7 @@ class FirewallsPageResult(NamedTuple):
     meta: Meta
 
 
-class FirewallsClient(BaseResourceClient):
+class FirewallsClient(ResourceClientBase):
     _client: Client
 
     actions: ResourceActionsClient
diff --git a/hcloud/floating_ips/client.py b/hcloud/floating_ips/client.py
@@ -3,7 +3,7 @@
 from typing import TYPE_CHECKING, Any, NamedTuple
 
 from ..actions import ActionsPageResult, BoundAction, ResourceActionsClient
-from ..core import BaseResourceClient, BoundModelBase, Meta
+from ..core import BoundModelBase, Meta, ResourceClientBase
 from ..locations import BoundLocation
 from .domain import CreateFloatingIPResponse, FloatingIP
 
@@ -139,7 +139,7 @@ class FloatingIPsPageResult(NamedTuple):
     meta: Meta
 
 
-class FloatingIPsClient(BaseResourceClient):
+class FloatingIPsClient(ResourceClientBase):
     _client: Client
 
     actions: ResourceActionsClient
diff --git a/hcloud/images/client.py b/hcloud/images/client.py
@@ -4,7 +4,7 @@
 from typing import TYPE_CHECKING, Any, NamedTuple
 
 from ..actions import ActionsPageResult, BoundAction, ResourceActionsClient
-from ..core import BaseResourceClient, BoundModelBase, Meta
+from ..core import BoundModelBase, Meta, ResourceClientBase
 from .domain import Image
 
 if TYPE_CHECKING:
@@ -112,7 +112,7 @@ class ImagesPageResult(NamedTuple):
     meta: Meta
 
 
-class ImagesClient(BaseResourceClient):
+class ImagesClient(ResourceClientBase):
     _client: Client
 
     actions: ResourceActionsClient
diff --git a/hcloud/isos/client.py b/hcloud/isos/client.py
@@ -2,7 +2,7 @@
 
 from typing import TYPE_CHECKING, Any, NamedTuple
 
-from ..core import BaseResourceClient, BoundModelBase, Meta
+from ..core import BoundModelBase, Meta, ResourceClientBase
 from .domain import Iso
 
 if TYPE_CHECKING:
@@ -20,7 +20,7 @@ class IsosPageResult(NamedTuple):
     meta: Meta
 
 
-class IsosClient(BaseResourceClient):
+class IsosClient(ResourceClientBase):
     _client: Client
 
     def get_by_id(self, id: int) -> BoundIso:
diff --git a/hcloud/load_balancer_types/client.py b/hcloud/load_balancer_types/client.py
@@ -2,7 +2,7 @@
 
 from typing import TYPE_CHECKING, Any, NamedTuple
 
-from ..core import BaseResourceClient, BoundModelBase, Meta
+from ..core import BoundModelBase, Meta, ResourceClientBase
 from .domain import LoadBalancerType
 
 if TYPE_CHECKING:
@@ -20,7 +20,7 @@ class LoadBalancerTypesPageResult(NamedTuple):
     meta: Meta
 
 
-class LoadBalancerTypesClient(BaseResourceClient):
+class LoadBalancerTypesClient(ResourceClientBase):
     _client: Client
 
     def get_by_id(self, id: int) -> BoundLoadBalancerType:
diff --git a/hcloud/load_balancers/client.py b/hcloud/load_balancers/client.py
@@ -7,7 +7,7 @@
 
 from ..actions import ActionsPageResult, BoundAction, ResourceActionsClient
 from ..certificates import BoundCertificate
-from ..core import BaseResourceClient, BoundModelBase, Meta
+from ..core import BoundModelBase, Meta, ResourceClientBase
 from ..load_balancer_types import BoundLoadBalancerType
 from ..locations import BoundLocation
 from ..metrics import Metrics
@@ -369,7 +369,7 @@ class LoadBalancersPageResult(NamedTuple):
     meta: Meta
 
 
-class LoadBalancersClient(BaseResourceClient):
+class LoadBalancersClient(ResourceClientBase):
     _client: Client
 
     actions: ResourceActionsClient
diff --git a/hcloud/locations/client.py b/hcloud/locations/client.py
@@ -2,7 +2,7 @@
 
 from typing import TYPE_CHECKING, Any, NamedTuple
 
-from ..core import BaseResourceClient, BoundModelBase, Meta
+from ..core import BoundModelBase, Meta, ResourceClientBase
 from .domain import Location
 
 if TYPE_CHECKING:
@@ -20,7 +20,7 @@ class LocationsPageResult(NamedTuple):
     meta: Meta
 
 
-class LocationsClient(BaseResourceClient):
+class LocationsClient(ResourceClientBase):
     _client: Client
 
     def get_by_id(self, id: int) -> BoundLocation:
diff --git a/hcloud/networks/client.py b/hcloud/networks/client.py
@@ -3,7 +3,7 @@
 from typing import TYPE_CHECKING, Any, NamedTuple
 
 from ..actions import ActionsPageResult, BoundAction, ResourceActionsClient
-from ..core import BaseResourceClient, BoundModelBase, Meta
+from ..core import BoundModelBase, Meta, ResourceClientBase
 from .domain import Network, NetworkRoute, NetworkSubnet
 
 if TYPE_CHECKING:
@@ -166,7 +166,7 @@ class NetworksPageResult(NamedTuple):
     meta: Meta
 
 
-class NetworksClient(BaseResourceClient):
+class NetworksClient(ResourceClientBase):
     _client: Client
 
     actions: ResourceActionsClient
diff --git a/hcloud/placement_groups/client.py b/hcloud/placement_groups/client.py
@@ -3,7 +3,7 @@
 from typing import TYPE_CHECKING, Any, NamedTuple
 
 from ..actions import BoundAction
-from ..core import BaseResourceClient, BoundModelBase, Meta
+from ..core import BoundModelBase, Meta, ResourceClientBase
 from .domain import CreatePlacementGroupResponse, PlacementGroup
 
 if TYPE_CHECKING:
@@ -43,7 +43,7 @@ class PlacementGroupsPageResult(NamedTuple):
     meta: Meta
 
 
-class PlacementGroupsClient(BaseResourceClient):
+class PlacementGroupsClient(ResourceClientBase):
     _client: Client
 
     def get_by_id(self, id: int) -> BoundPlacementGroup:
diff --git a/hcloud/primary_ips/client.py b/hcloud/primary_ips/client.py
@@ -3,7 +3,7 @@
 from typing import TYPE_CHECKING, Any, NamedTuple
 
 from ..actions import BoundAction, ResourceActionsClient
-from ..core import BaseResourceClient, BoundModelBase, Meta
+from ..core import BoundModelBase, Meta, ResourceClientBase
 from .domain import CreatePrimaryIPResponse, PrimaryIP
 
 if TYPE_CHECKING:
@@ -97,7 +97,7 @@ class PrimaryIPsPageResult(NamedTuple):
     meta: Meta
 
 
-class PrimaryIPsClient(BaseResourceClient):
+class PrimaryIPsClient(ResourceClientBase):
     _client: Client
 
     actions: ResourceActionsClient
diff --git a/hcloud/server_types/client.py b/hcloud/server_types/client.py
@@ -2,7 +2,7 @@
 
 from typing import TYPE_CHECKING, Any, NamedTuple
 
-from ..core import BaseResourceClient, BoundModelBase, Meta
+from ..core import BoundModelBase, Meta, ResourceClientBase
 from .domain import ServerType
 
 if TYPE_CHECKING:
@@ -20,7 +20,7 @@ class ServerTypesPageResult(NamedTuple):
     meta: Meta
 
 
-class ServerTypesClient(BaseResourceClient):
+class ServerTypesClient(ResourceClientBase):
     _client: Client
 
     def get_by_id(self, id: int) -> BoundServerType:
diff --git a/hcloud/servers/client.py b/hcloud/servers/client.py
@@ -6,7 +6,7 @@
 from dateutil.parser import isoparse
 
 from ..actions import ActionsPageResult, BoundAction, ResourceActionsClient
-from ..core import BaseResourceClient, BoundModelBase, Meta
+from ..core import BoundModelBase, Meta, ResourceClientBase
 from ..datacenters import BoundDatacenter
 from ..firewalls import BoundFirewall
 from ..floating_ips import BoundFloatingIP
@@ -482,7 +482,7 @@ class ServersPageResult(NamedTuple):
     meta: Meta
 
 
-class ServersClient(BaseResourceClient):
+class ServersClient(ResourceClientBase):
     _client: Client
 
     actions: ResourceActionsClient
diff --git a/hcloud/ssh_keys/client.py b/hcloud/ssh_keys/client.py
@@ -2,7 +2,7 @@
 
 from typing import TYPE_CHECKING, Any, NamedTuple
 
-from ..core import BaseResourceClient, BoundModelBase, Meta
+from ..core import BoundModelBase, Meta, ResourceClientBase
 from .domain import SSHKey
 
 if TYPE_CHECKING:
@@ -41,7 +41,7 @@ class SSHKeysPageResult(NamedTuple):
     meta: Meta
 
 
-class SSHKeysClient(BaseResourceClient):
+class SSHKeysClient(ResourceClientBase):
     _client: Client
 
     def get_by_id(self, id: int) -> BoundSSHKey:
diff --git a/hcloud/volumes/client.py b/hcloud/volumes/client.py
@@ -3,7 +3,7 @@
 from typing import TYPE_CHECKING, Any, NamedTuple
 
 from ..actions import ActionsPageResult, BoundAction, ResourceActionsClient
-from ..core import BaseResourceClient, BoundModelBase, Meta
+from ..core import BoundModelBase, Meta, ResourceClientBase
 from ..locations import BoundLocation
 from .domain import CreateVolumeResponse, Volume
 
@@ -135,7 +135,7 @@ class VolumesPageResult(NamedTuple):
     meta: Meta
 
 
-class VolumesClient(BaseResourceClient):
+class VolumesClient(ResourceClientBase):
     _client: Client
 
     actions: ResourceActionsClient
diff --git a/tests/unit/core/test_client.py b/tests/unit/core/test_client.py
@@ -6,7 +6,7 @@
 import pytest
 
 from hcloud.actions import ActionsPageResult
-from hcloud.core import BaseDomain, BaseResourceClient, BoundModelBase, Meta
+from hcloud.core import BaseDomain, BoundModelBase, Meta, ResourceClientBase
 
 
 class TestBoundModelBase:
@@ -99,15 +99,15 @@ def test_equality(self, bound_model_class, client):
         assert bound_model_a != bound_model_b.data_model
 
 
-class TestBaseResourceClient:
+class TestResourceClientBase:
     @pytest.fixture()
     def client_class_constructor(self):
         def constructor(json_content_function):
             class CandiesPageResult(NamedTuple):
                 candies: list[Any]
                 meta: Meta
 
-            class CandiesClient(BaseResourceClient):
+            class CandiesClient(ResourceClientBase):
                 def get_list(self, status=None, page=None, per_page=None):
                     json_content = json_content_function(page)
                     results = [
@@ -122,7 +122,7 @@ def get_list(self, status=None, page=None, per_page=None):
     @pytest.fixture()
     def client_class_with_actions_constructor(self):
         def constructor(json_content_function):
-            class CandiesClient(BaseResourceClient):
+            class CandiesClient(ResourceClientBase):
                 def get_actions_list(self, status, page=None, per_page=None):
                     json_content = json_content_function(page)
                     results = [
