Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly read/write game result from/to .sgf files #373

Open
herzbube opened this issue Jun 3, 2022 · 1 comment
Open

Properly read/write game result from/to .sgf files #373

herzbube opened this issue Jun 3, 2022 · 1 comment

Comments

@herzbube
Copy link
Owner

herzbube commented Jun 3, 2022

Currently if the app enters scoring mode and the user performs all the steps necessary to calculate a proper score, that score is forgotten as soon as the app leaves scoring mode.

Instead the score should somehow be stored in one of the Go classes (GoGame?) when the app leaves scoring mode. From there it can then be written to .sgf.

Conversely, when an .sgf is read, if an SGFCGameResult is available its information should be evaluated and stored in one of the Go classes (GoGame?).

@herzbube herzbube added this to the Soon milestone Jun 3, 2022
@herzbube herzbube self-assigned this Jun 3, 2022
@herzbube
Copy link
Owner Author

herzbube commented Jun 3, 2022

Some thoughts

  • GoGameHasEndedReason may need to be adjusted. See SgfUtilities::gameResultForGoGameHasEndedReason().
  • How to apply already existing scoring information when the app enters scoring mode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant