Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support Heroku Private Spaces Logging for resource heroku_space and heroku_drain #207

Open
jayal opened this issue Jun 25, 2019 · 5 comments
Labels
Heroku API Support Ticket/PR is blocked on the Heroku API supporting the use case

Comments

@jayal
Copy link

jayal commented Jun 25, 2019

Heroku Private Spaces supports setting up a heroku drain for a space during space creation. This log drain can later be updated via heroku_drain.

Terraform Version

Terraform v0.11.14

Heroku Provider Version

Terraform v0.11.14
+ provider.heroku v2.0.1

Affected Resource(s)

Please list the resources as a list, for example:

  • heroku_space
  • heroku_drain

References

@mars
Copy link
Member

mars commented Jun 25, 2019

Unfortunately, the Platform API does not support passing this option as part of Private Space create method:
https://devcenter.heroku.com/articles/platform-api-reference#space-create
https://devcenter.heroku.com/articles/json-schema-for-platform-api

I'll look into if that's something that's been overlooked, or actually blocked somehow from becoming part of the generally available, documented Platform API.

@mars mars added the Heroku API Support Ticket/PR is blocked on the Heroku API supporting the use case label Jun 25, 2019
@acorncom
Copy link

@mars any updates on this front? Working to setup a client who needs a private space with log draining and we'd rather not have to do it manually and then hook Terraform up after the fact

@davidji99
Copy link
Collaborator

davidji99 commented Nov 5, 2020

Hi @acorncom,

I recently did an update to the heroku-go but unfortunately, the Platform API schema still does not have passing the log drain URL as an option.

I ended up spiking on an opinionated resource in my herokux provider that'll enable users to create a shield private space with logging enabled on creation.

Hope this helps.

@acorncom
Copy link

@davidji99 thx much, that's quite helpful!

@mars
Copy link
Member

mars commented Feb 14, 2023

It looks like Private Space creation does now support a log_drain_url:
https://devcenter.heroku.com/articles/platform-api-reference#space-create

…and it's a writable option in the API schema:
https://github.com/heroku/heroku-go/blob/master/v5/heroku.go#L3962

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Heroku API Support Ticket/PR is blocked on the Heroku API supporting the use case
Projects
None yet
Development

No branches or pull requests

4 participants