Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newtype for launch::Slice path globs #486

Open
Malax opened this issue Aug 17, 2022 · 1 comment
Open

Add newtype for launch::Slice path globs #486

Malax opened this issue Aug 17, 2022 · 1 comment
Labels
enhancement New feature or request libcnb-data

Comments

@Malax
Copy link
Member

Malax commented Aug 17, 2022

As per spec, these are Go standard library globs and must follow that syntax (https://pkg.go.dev/path/filepath#Match). This is potentially more complex to implement as a newtype than the ones we currently have.

@Malax Malax added enhancement New feature or request libcnb-data labels Aug 17, 2022
@edmorley
Copy link
Member

edmorley commented Aug 30, 2022

I'd be inclined to wontfix this to be honest (if we're going to have to reimplement Go path globs). Usage of slice layers is likely going to be pretty rare, and people using it can just read the docs. Whilst it's nice that libcnb.rs can prevent a subset of errors at runtime though typing and nice DX, I don't think it's viable for it to prevent every class of issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request libcnb-data
Projects
None yet
Development

No branches or pull requests

2 participants