Merge pull request #91 from heroku/fix/correct-error-message-when-no-app

Corrects error message when app not found

Author: jasononaquest

src/commands/ai/models/info.ts

@@ -3,7 +3,7 @@ import {flags} from '@heroku-cli/command'
 import {Args, ux} from '@oclif/core'
 import Command from '../../../lib/base'
 import type {ModelResource} from '@heroku/ai'
-import appAddons from '../../../lib/ai/models/app_addons'
+
 import * as Heroku from '@heroku-cli/schema'
 
 export default class Info extends Command {
@@ -74,7 +74,9 @@ export default class Info extends Command {
     } else {
       const provisionedModelsInfo: Record<string, string | undefined>[] = []
       const inferenceRegex = /inference/
-      const addonsResponse = await appAddons(this.config, app)
+      const {body: addonsResponse} = await this.heroku.get<Heroku.AddOn>(`/apps/${app}/addons`, {
+        headers: {'Accept-Expansion': 'plan'},
+      })
 
       for (const addonInfo of addonsResponse as Array<Heroku.AddOn>) {
         const addonType = addonInfo.addon_service?.name || ''

src/lib/ai/models/app_addons.ts

@@ -168,4 +168,35 @@ describe('ai:models:info', function () {
       }
     })
   })
+
+  context('when app does not exist', function () {
+    beforeEach(function () {
+      process.env = {}
+      api = nock('https://api.heroku.com:443')
+    })
+
+    afterEach(function () {
+      process.env = env
+      nock.cleanAll()
+    })
+
+    it('shows clean error message without addon context', async function () {
+      api
+        .get('/apps/nonexistent-app/addons')
+        .reply(404, {
+          id: 'not_found',
+          message: 'Couldn\'t find that app.',
+        })
+
+      try {
+        await runCommand(Cmd, [
+          '--app',
+          'nonexistent-app',
+        ])
+      } catch (error) {
+        const {message} = error as CLIError
+        expect(stripAnsi(message)).to.equal('Couldn\'t find that app.\n\nError ID: not_found')
+      }
+    })
+  })
 })