Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin-mtls is not installing using heroku cli #2761

Closed
shiladityab24 opened this issue Mar 30, 2024 · 4 comments
Closed

plugin-mtls is not installing using heroku cli #2761

shiladityab24 opened this issue Mar 30, 2024 · 4 comments

Comments

@shiladityab24
Copy link

shiladityab24 commented Mar 30, 2024

Do you want to request a feature or report a bug?

If bug, first try running heroku update and setting DEBUG=* to see extra debug information.

What is the current behavior?

Unable to install mtls plugin for generating certificates using mtls method in order to access private heroku postgres db using heroku cli. Reason due to its outdated nodejs version

Steps to reproduce:

  1. Open cmd in windows or terminal in linux/macos, type heroku version to check whether the latest version is installed or not.
  2. If latest version is not installed, type heroku update.
  3. If latest version installed , type heroku plugins:install @heroku-cli/plugin-mtls.

image

What is the expected behavior?

Current heroku version heroku/8.11.1 win32-x64 node-v16.20.2
OS: Windows 11
It should show that once mtls plugins installed successfully , after typing heroku plugins in the cmd,it should show that mtls plugins is installed along with its version
Eg:

image

@AaronRustad
Copy link

AaronRustad commented Apr 1, 2024

I am seeing this too. Though I logged an issue here. It seems one of the dependencies may have changes its requirements and since the cli bundles its own version of node, there is a conflict.

This is happening on macOS 14.4.1 (M1) and Debian inside of Docker.

@AaronRustad
Copy link

I received an email from Heroku support indicating that this is a know issue that they are looking into. I was able to downgrade successfully.

heroku plugins:install mtls@0.8.2

@shiladityab24
Copy link
Author

Hey @AaronRustad thanks for the quick update.Now I want to understand why they are not upgrading the nodejs version of the heroku cli because its a way outdated. What factors or concerns does stopping them to upgrade Nodejs to the latest version.

@justinwilaby
Copy link
Contributor

v0.9.1 of the MTLS plugin was published with a fix to this issue. Please note that this is an issue with the plugin-plugins product which should be solved with the newest release.

Root Cause Analysis

plugin-plugins uses Yarn to install plugins which erroneously installs all devDependencies defined in the plugin's package.json. If a dependency defined in the devDependencies requires a different node version than the heroku cli, installation fails. This behavior is incorrect because devDependencies are not used in the production code for the plugin and may dramatically increase the number of unused files downloaded on the user's machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants