Skip to content

Commit 9833c4e

Browse files
authored
fix(run-v5): log displayer eventsource events (#1020)
1 parent e194808 commit 9833c4e

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

packages/run-v5/lib/log_displayer.js

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,15 +42,20 @@ function readLogsV2 (logplexURL) {
4242
})
4343

4444
es.onerror = function (err) {
45-
if (!isTail) {
46-
resolve()
45+
if (err && (err.status || err.message)) {
46+
const msg = (isTail && (err.status === 404 || err.status === 403)) ?
47+
'Log stream timed out. Please try again.' :
48+
`Logs eventsource failed with: ${err.status} ${err.message}`
49+
reject(msg)
4750
es.close()
4851
}
4952

50-
if (err && (err.status === 404 || err.status === 403)) {
51-
reject(new Error('Log stream timed out. Please try again.'))
53+
if (!isTail) {
54+
resolve()
5255
es.close()
5356
}
57+
58+
// should only land here if --tail and no error status or message
5459
}
5560

5661
es.onmessage = function (e) {

0 commit comments

Comments
 (0)