This repository was archived by the owner on May 23, 2024. It is now read-only.
Fix tarball creation, for real :) #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(ping @kennethreitz) |
|
🍰 |
kennethreitz
added a commit
that referenced
this pull request
Apr 8, 2014
Fix tarball creation, for real :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent change caused empty folders to be discarded.
I looked into the issue again. The old
os.path.basenamecall returned an empty string only ifdirhad a trailing slash. Otherwise, it would return the dir name. So this was a bit brittle, because depending on whether or not someone had a trailing slash in the "Build Dir" comment at the top of their file, they'd get different results.Passing an empty string as
arcnamealways causes the empty entry in the tarball. This seems to be related to howarcnameis passed through arealpathcall.The fix, then, is to simply iterate over the top level of the given directory, and add those entries individually (can be files or dirs). Much simpler code, too :)