Skip to content

Commit 7f1afbd

Browse files
author
Marc Shilling
committed
update Android installation instructions for React Native 0.18+
1 parent d4c15bb commit 7f1afbd

File tree

1 file changed

+16
-31
lines changed

1 file changed

+16
-31
lines changed

README.md

Lines changed: 16 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,7 @@ dependencies {
4747
<!-- add following permissions -->
4848
<uses-permission android:name="android.permission.CAMERA" />
4949
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
50-
<uses-feature android:name="android.hardware.camera"
51-
android:required="true"/>
50+
<uses-feature android:name="android.hardware.camera" android:required="true"/>
5251
<uses-feature android:name="android.hardware.camera.autofocus" />
5352
<!-- -->
5453
...
@@ -59,41 +58,27 @@ dependencies {
5958
import android.content.Intent; // import
6059
import com.imagepicker.ImagePickerPackage; // import
6160

62-
public class MainActivity extends Activity implements DefaultHardwareBackBtnHandler {
61+
public class MainActivity extends ReactActivity {
6362

64-
private ReactInstanceManager mReactInstanceManager;
65-
private ReactRootView mReactRootView;
66-
67-
// declare package
68-
private ImagePickerPackage mImagePicker;
63+
private ImagePickerPackage mImagePicker; // <--- ADD THIS
6964

65+
/**
66+
* A list of packages used by the app. If the app uses additional views
67+
* or modules besides the default ones, add more packages here.
68+
*/
7069
@Override
71-
protected void onCreate(Bundle savedInstanceState) {
72-
super.onCreate(savedInstanceState);
73-
mReactRootView = new ReactRootView(this);
74-
75-
// instantiate package
76-
mImagePicker = new ImagePickerPackage(this);
77-
78-
mReactInstanceManager = ReactInstanceManager.builder()
79-
.setApplication(getApplication())
80-
.setBundleAssetName("index.android.bundle")
81-
.setJSMainModuleName("index.android")
82-
.addPackage(new MainReactPackage())
83-
84-
// register package here
85-
.addPackage(mImagePicker)
86-
87-
.setUseDeveloperSupport(BuildConfig.DEBUG)
88-
.setInitialLifecycleState(LifecycleState.RESUMED)
89-
.build();
90-
mReactRootView.startReactApplication(mReactInstanceManager, "AwesomeProject", null);
91-
setContentView(mReactRootView);
70+
protected List<ReactPackage> getPackages() {
71+
mImagePicker = new ImagePickerPackage(this); // <--- AND THIS
72+
73+
return Arrays.<ReactPackage>asList(
74+
new MainReactPackage(),
75+
mImagePicker // <--- AND THIS
76+
);
9277
}
9378

9479
...
95-
96-
// handle onActivityResult
80+
81+
// AND ADD THIS WHOLE METHOD
9782
@Override
9883
public void onActivityResult(final int requestCode, final int resultCode, final Intent data) {
9984
super.onActivityResult(requestCode, resultCode, data);

0 commit comments

Comments
 (0)