Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fetch version basis #213

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Add fetch version basis #213

merged 1 commit into from
Jan 15, 2024

Conversation

BlowaXD
Copy link
Contributor

@BlowaXD BlowaXD commented Jan 12, 2024 •
edited
Loading

This PR intends to continue my work from: #210 and implement "fetch version" gRPC APIs
Added a basic test with it

Testing scenario:

- Publishing Package 1.0.0
- Publishing Package 1.1.1
- Fetching Version with requirement `>=1.1`
- Ensure fetched versions only contains `1.1.1`

@BlowaXD BlowaXD self-assigned this Jan 15, 2024
@BlowaXD BlowaXD marked this pull request as ready for review January 15, 2024 10:45
@mara-schulke mara-schulke added complexity::low Issues or ideas with a low implementation cost component::registry Everything related to the buffrs registry type::feature Shipping or drafting a new feature for this product priority::medium This is not urgent, but we should do this. labels Jan 15, 2024
@mara-schulke mara-schulke added this to the Registry milestone Jan 15, 2024
@BlowaXD BlowaXD closed this Jan 15, 2024
@BlowaXD BlowaXD reopened this Jan 15, 2024
@mara-schulke mara-schulke merged commit ea802f1 into main Jan 15, 2024
6 checks passed
@mara-schulke mara-schulke deleted the vg/fetch-versions branch January 15, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mara-schulke mara-schulke mara-schulke approved these changes

Assignees

@BlowaXD BlowaXD

Labels
complexity::low Issues or ideas with a low implementation cost component::registry Everything related to the buffrs registry priority::medium This is not urgent, but we should do this. type::feature Shipping or drafting a new feature for this product
Projects
Buffrs
Status: Done
Milestone
Registry
Development

Successfully merging this pull request may close these issues.
2 participants
@BlowaXD @mara-schulke