Make static lifetime of constants explicit

[JoeHut]

The most recent version of clippy complains about missing explicit lifetime annotators for constants.

[mara-schulke]

As of 1.37 there is a lint in place which encourage omitting this:

https://rust-lang.github.io/rust-clippy/stable/index.html#/redundant_static_lifetimes

Can you give me a reference when this has been changed (and in which version?)

[JoeHut]

See the discussion here: rust-lang/rust#115010
tbh, I just saw that #167 doesn't pass CI because of this and couldn't reproduce it before a rustup update.

But then again, I don't see "elided_lifetimes_in_associated_constant" in https://rust-lang.github.io/rust-clippy/stable/index.html ?!

[xfbs]

I was quite confused by this, let me shine some light here!

As of 1.37 there is a lint in place which encourage omitting this:

https://rust-lang.github.io/rust-clippy/stable/index.html#/redundant_static_lifetimes

This is still in place — basically, when you declare a static, you do it like this (without the explicit 'static lifetime):

static MY_STATIC: &str = "important stuff here";

This has not changed.

The most recent version of clippy complains about missing explicit lifetime annotators for constants.
See the discussion here: rust-lang/rust#115010
tbh, I just saw that #167 doesn't pass CI because of this and couldn't reproduce it before a rustup update.

Yes, so crucially, this is not about lifetimes in constants, but lifetimes in associated constants. So here, we don't have a simple constant, we have a constant which is associated to a type, like this:

impl MyType {
    const MY_CONST: &'static str = "abc";
}

In this situation, we must give an explicit lifetime at the moment, according to that issue you linked.

But then again, I don't see "elided_lifetimes_in_associated_constant" in https://rust-lang.github.io/rust-clippy/stable/index.html ?!

Correct, this is not a clippy warning, but rather a compiler warning.

[xfbs]

LGTM.

According to rust-lang/rust#115010, we need to make these changes as they will become a hard error in the future.