Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Ensure NumPy-compatibility of test_statistics.py #1232

Closed
mrfh92 opened this issue Oct 6, 2023 · 7 comments
Closed

[Bug]: Ensure NumPy-compatibility of test_statistics.py #1232

mrfh92 opened this issue Oct 6, 2023 · 7 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers interoperability testing Implementation of tests, or test-related issues

Comments

@mrfh92
Copy link
Collaborator

mrfh92 commented Oct 6, 2023

What happened?

In test_statistics.py, NumPy throws the following deprecation warning:

DeprecationWarning: the `interpolation=` argument to percentile was renamed to `method=`, which has additional options.
Users of the modes 'nearest', 'lower', 'higher', or 'midpoint' are encouraged to review the method they used. (Deprecated NumPy 1.22)

Although we only use NumPy here to get the "correct" result to which our Heat result is compared, we should keep this up-to-date.

Code snippet triggering the error

No response

Error message or erroneous outcome

No response

Version

1.3.x

Python version

None

PyTorch version

None

MPI version

No response

@mrfh92 mrfh92 added bug Something isn't working good first issue Good for newcomers interoperability testing Implementation of tests, or test-related issues labels Oct 6, 2023
@RengarajR404
Copy link

Heyy
Can you assign me to this issue?

@mrfh92 mrfh92 assigned mrfh92 and unassigned mrfh92 Oct 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

@mrfh92
Copy link
Collaborator Author

mrfh92 commented Oct 12, 2023

Further deprecation warning (might depend on NumPy-version used, of course):

test_arithmetics.py:620: DeprecationWarning: `np.math` is a deprecated alias for the standard library `math` module (Deprecated Numpy 1.25). Replace usages of `np.math` with `math`

@mrfh92
Copy link
Collaborator Author

mrfh92 commented Oct 14, 2023

@RengarajR404 feel free to ask if there are any questions :)

@samadpls
Copy link
Contributor

Hey @RengarajR404, if you're not actively working on this issue, can I take it over? Thanks!

@samadpls
Copy link
Contributor

Further deprecation warning related to NumPy 1.25:

factories.py:107: DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ensure you extract a single element from your array before performing this operation.

@FOsterfeld FOsterfeld self-assigned this Jan 2, 2024
@mrfh92
Copy link
Collaborator Author

mrfh92 commented Feb 5, 2024

has been addressed in #1315 and #1337

@mrfh92 mrfh92 closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers interoperability testing Implementation of tests, or test-related issues
Projects
None yet
Development

No branches or pull requests

4 participants