Convert registry to k8s.gcr.io #3141
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
I am unfamiliar with the rules for version increments - does this really warrant that? |
|
@thockin Charts are immutable. We want people to be able to check for things like a changed hash at a version. So, the version matters. I'll take this one on and carry it home. Might take a couple weeks given the holidays but poke me if I don't get it done. |
See helm#3141 for more detail
|
@thockin unless there's an objection, we're going to break this up into 12 separate pull requests. One for each chart so we can make sure all tests pass and the charts are immutable. We'll take care of it. |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
See #3141 for more detail
| @@ -15,7 +15,7 @@ | |||
| all: push | |||
|
|
|||
| TAG = 0.5 | |||
| PREFIX = gcr.io/google_containers/mongodb-install | |||
| PREFIX = k8s.gcr.io/mongodb-install | |||
There was a problem hiding this comment.
PREFIX = staging-k8s.gcr.io/mongodb-install
k8s-ci-robot
added
size/XS
|
Since you're merging these piecemeal, I'll repurpose this to the next tweak. Pushes go to one place, pulls from another. |
|
/retest |
|
@foxish Any idea why these tests are failing on the mongodb-replicast chart? |
|
/retest |
|
/assign |
|
/retest |
|
This test appears to be failing be cause our CI is not waiting until the RS is completely deployed, in the latest result only 2 of 3 replicas was up/running. Testing manually showed that this does indeed work. |
|
/retest |
|
@viglesiasce @unguiculus I think the issue is in how we test for statefulsets. When the first replica comes online all the pods are ready so it proceeds with the tests. If there are multiple replicas those start to come online but aren't ready. Testing shouldn't proceed until all the replicas are up. This is a bug in CI, I think. |
|
/retest A change to CI was merged that, I think, fixes the issue. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattfarina, thockin The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
@mattfarina I see a handful of new uses of the old names. Do youw ant me to send a PR or can you handle it? |
This PR was auto-generated. Please apply human expertise to review for correctness.
Followup to kubernetes/kubernetes#54174 and kubernetes/kubernetes#57824
xref kubernetes/release#281