fix: allow package versions with extended semversioning#406
Open
fix: allow package versions with extended semversioning#406
Conversation
Signed-off-by: jose <jose.pedrosa@reddit.com>
|
Is there a plan to merge this PR to mainstream ? |
Member
|
Can you fix conflicts, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is reported that chart-releaser fails when the version number has some separator: helm/chart-releaser-action#56
When a tag has the + symbol ie: 2.0.0+Chart1, which is semver compliant see helm/chart-releaser-action#56.
When githubs return the download URL for the chart, it contains escape character %2B, but the actual filename is +Chart1. This causes the log/trace linked in the issue above.
This PR adds the filenameParameter to the addToIndexFile function. So instead of receiving the URL only, it receives the url and the correct filename for the asset, that later parts of the code will try to open.
Added test cases to validate this scenario.
Also this PR adds support for ssh url syntax for remotes, so it also can be executed locally.