Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newlines in the chart description are not considered #125

Open
marcofranssen opened this issue Jun 25, 2021 · 1 comment
Open

Newlines in the chart description are not considered #125

marcofranssen opened this issue Jun 25, 2021 · 1 comment

Comments

@marcofranssen
Copy link

marcofranssen commented Jun 25, 2021

In our helm chart we are using a description that contains new lines.

https://github.com/philips-labs/helm-charts/blob/spire-0.2.1/charts/spire/Chart.yaml#L3

These are not handled when creating the Github release, causing all this information to end up on the same line.

https://github.com/philips-labs/helm-charts/releases/tag/spire-0.2.1

⚠️ Please note: we have manually updated our release descriptions in Github to resolve it for now.

Could this be caused by https://github.com/helm/helm/blob/main/pkg/chart/loader/load.go#L84 which is called from the chart-releaser?

@marcofranssen
Copy link
Author

Found the following:

ghodss/yaml#56

This package is used in sigs.k8s.io/yaml.

sigs.k8s.io/yaml is used in https://github.com/helm/helm/blob/main/pkg/chart/loader/load.go#L84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant