Merge pull request #159 from hellokitty-coding-club/feat/product-flavor

[FEAT] flavorDimension 활용해서 dev, prod 분리 (#158)

Author: KxxHyoRim

.github/workflows/prBuilder.yml

@@ -60,7 +60,7 @@ jobs:
           appId: ${{ secrets.FIREBASE_APP_ID }}
           token: ${{ secrets.FIREBASE_TOKEN }}
           groups: hello-kitty-coding-club
-          file: app/build/outputs/apk/debug/app-debug.apk
+          file: app/build/outputs/apk/dev/debug/app-dev-debug.apk
           releaseNotes: |
             ${{ github.event.pull_request.title }}
             ${{ github.event.pull_request.html_url }}

app/build.gradle.kts

@@ -1,3 +1,5 @@
+@file:Suppress("UnstableApiUsage")
+
 import org.jetbrains.kotlin.konan.properties.Properties
 
 val lgtmPropertiesFile = rootProject.file("lgtm.properties")
@@ -45,6 +47,23 @@ android {
         }
     }
 
+    flavorDimensions += "version"
+    productFlavors {
+        create("prod") {
+            dimension = "version"
+            manifestPlaceholders["appLabel"] = "LGTM"
+            buildConfigField("boolean", "IS_PROD", "true")
+            buildConfigField("boolean", "IS_DEV", "false")
+        }
+        create("dev") {
+            dimension = "version"
+            applicationIdSuffix = ".dev"
+            manifestPlaceholders["appLabel"] = "(Dev)LGTM"
+            buildConfigField("boolean", "IS_PROD", "false")
+            buildConfigField("boolean", "IS_DEV", "true")
+        }
+    }
+
     buildFeatures {
         buildConfig = true
     }

app/src/main/AndroidManifest.xml

@@ -8,7 +8,7 @@
         android:name=".LGTMApplication"
         android:allowBackup="false"
         android:icon="@mipmap/ic_launcher"
-        android:label="@string/app_name"
+        android:label="${appLabel}"
         android:roundIcon="@mipmap/ic_launcher_round"
         android:supportsRtl="true"
         android:theme="@style/Theme.LGTMAndroid"

common-ui/src/main/java/com/lgtm/android/common_ui/constant/InfoType.kt

@@ -21,8 +21,8 @@ enum class InfoType(
         R.drawable.ic_info_red
     ),
     VALID_REAL_NAME(R.color.red, R.string.write_correct_name, true, R.drawable.ic_info_red),
-    OVER_12_MONTHS_EXPERIENCE_REQUIRED(
-        R.color.red, R.string.over_12_month_experience_required,
+    EXPERIENCE_REQUIRED(
+        R.color.red, R.string.career_experience_required,
         true, R.drawable.ic_info_red
     ),
     GITHUB_URL_ONLY(R.color.red, R.string.github_url_only, true, R.drawable.ic_info_red),

common-ui/src/main/res/values/strings.xml

@@ -44,7 +44,7 @@
     <string name="cannot_use_space">띄어쓰기는 사용할 수 없습니다.</string>
     <string name="cannot_only_use_space">띄어쓰기만 입력할 수 없습니다.</string>
     <string name="write_correct_name">올바른 실명을 입력해 주세요.</string>
-    <string name="over_12_month_experience_required">경력 12개월 이상만 가입할 수 있습니다.</string>
+    <string name="career_experience_required">현업 개발자만 리뷰어 활동이 가능해요</string>
     <string name="duplicate_nickname">중복된 닉네임입니다.</string>
     <string name="can_use">사용 가능합니다.</string>
     <string name="empty_value"></string>

feature/auth/src/main/java/com/lgtm/android/auth/ui/signup/SignUpViewModel.kt

@@ -275,7 +275,7 @@ class SignUpViewModel @Inject constructor(
         val careerPeriod = careerPeriod.value
         careerPeriodInfoStatus.value = when {
             careerPeriod == null -> InfoType.NONE
-            careerPeriod < 12 -> InfoType.OVER_12_MONTHS_EXPERIENCE_REQUIRED
+            careerPeriod < 1 -> InfoType.EXPERIENCE_REQUIRED
             else -> InfoType.NONE
         }
     }