Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new theme keys for LSP diagnostic tags for dark_plus #9949

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

David-Else
Copy link
Contributor

Now #9780 is merged I have added the new theme keys.

Deprecated used to look like:

Screenshot from 2024-03-20 19-22-40

Now it looks like:

Screenshot from 2024-03-20 19-35-28

I can't find any code to show unnecessary, but the dim modifier works in general in the theme and does exactly as expected, it just dims the text slightly.

@kirawi Looks good to you?

@the-mikedavis
Copy link
Member

For testing unnecessary code you can try:

let x = todo!();
let y = todo!(); // tagged with unnecessary

I believe rust-analyzer also uses it for features that are not enabled, for example the blocks in helix-term/src/application.rs marked with #[cfg(feature = "integration")]

@David-Else
Copy link
Contributor Author

David-Else commented Mar 20, 2024

Cheers, here is an example using #[cfg(feature = "integration")] to show the dimmed effect of unnecessary in dark_plus. It is quite subtle:

Screenshot from 2024-03-20 19-57-38

and here it is for the default theme:

Screenshot from 2024-03-20 20-01-09

@the-mikedavis the-mikedavis added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Mar 20, 2024
@the-mikedavis the-mikedavis requested a review from kirawi March 20, 2024 20:52
Copy link
Member

@kirawi kirawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@pascalkuthe pascalkuthe merged commit 52a0734 into helix-editor:master Mar 20, 2024
6 checks passed
@David-Else David-Else deleted the tags branch March 21, 2024 09:46
Desdaemon pushed a commit to Desdaemon/helix that referenced this pull request Mar 26, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants