-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
smartcase regex search #761
Conversation
e852678
to
0ee3cca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the desired behaviour for select_regex? Never enabled? Configured with a separate option?
Default it to true
.
Where would the regex builder live in helix-core?
Let's skip this for now, this PR is just a temporary workaround until we switch over to regex-automata in #211
0ee3cca
to
ab90261
Compare
Thanks :) Fixed your comments. Also took the liberty of removing the todo and a comment. |
ab90261
to
6f5b95b
Compare
Thanks! Looks like there's a conflict, and I'd also mention the new option in the configuration section of the book. Other than that it looks good for merge. |
6f5b95b
to
799334d
Compare
799334d
to
6d7da7b
Compare
6d7da7b
to
020de7c
Compare
First stab at smartcase search.
Some thoughts:
select_regex
? Never enabled? Configured with a separate option?helix-core
? (so it can be used for other ui:s than term and Initial implementation of global search #651)(edit: i didn't look at 651:s implementation before. guess the pr's not a reason for moving it to
helix-core
..)