Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand contributing docs #5967

Merged
merged 5 commits into from
Feb 19, 2023
Merged

Expand contributing docs #5967

merged 5 commits into from
Feb 19, 2023

Conversation

magopian
Copy link
Contributor

@magopian magopian commented Feb 13, 2023 •
edited
Loading

Just a couple tips and tricks that @pascalkuthe gave on the matrix server

the-mikedavis
the-mikedavis reviewed Feb 13, 2023
View reviewed changes
docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
@the-mikedavis the-mikedavis added the A-documentation Area: Documentation improvements label Feb 13, 2023
the-mikedavis
the-mikedavis reviewed Feb 14, 2023
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor comments, I think this looks good otherwise 👍

docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
@magopian
Copy link
Contributor Author

Hopefully all fixed now, sorry for the back and forth, I should have caught those earlier. Thanks for pointing the issues/typos out!

pascalkuthe
pascalkuthe approved these changes Feb 18, 2023
View reviewed changes
Copy link
Member

@pascalkuthe pascalkuthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 👍 I have answered questions like these quite a few tines on matrix so it's good to document this somewhere.

@pascalkuthe pascalkuthe added the S-waiting-on-review Status: Awaiting review from a maintainer. label Feb 18, 2023
@the-mikedavis the-mikedavis changed the title Slightly longer contributing docs Expand contributing docs Feb 19, 2023
@the-mikedavis the-mikedavis merged commit 31b0c75 into helix-editor:master Feb 19, 2023
thancock20 pushed a commit to thancock20/helix that referenced this pull request Feb 19, 2023
@magopian @thancock20
Expand contributing docs (helix-editor#5967)
5029502
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
@magopian @wes-adams
Expand contributing docs (helix-editor#5967)
98ef078
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalkuthe pascalkuthe pascalkuthe approved these changes

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-documentation Area: Documentation improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magopian @the-mikedavis @pascalkuthe