Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWK support #3528

Merged
merged 1 commit into from
Aug 24, 2022
Merged

AWK support #3528

merged 1 commit into from
Aug 24, 2022

Conversation

ath3
Copy link
Contributor

@ath3 ath3 commented Aug 24, 2022 •
edited
Loading

awk_example

@ath3 ath3 force-pushed the master branch 2 times, most recently from 3aff5c6 to 4c188e6 Compare August 24, 2022 13:49
@the-mikedavis
Copy link
Member

I think we should be able to inject awk into bash. Something like this?

; runtime/queries/bash/injections.scm
(command
  name: (command_name (word) @_command)
  argument: (raw_string) @injection.content
 (#eq? @_command "awk")
 (#set! injection.language "awk"))

@ath3
Copy link
Contributor Author

ath3 commented Aug 24, 2022

Good idea, should we also support shell scripts calling nawk and gawk specifically?

; runtime/queries/bash/injections.scm
(command
  name: (command_name (word) @_command)
  argument: (raw_string) @injection.content
 (#match? @_command "^[gn]?awk$")
 (#set! injection.language "awk"))

@the-mikedavis the-mikedavis merged commit 45add73 into helix-editor:master Aug 24, 2022
@the-mikedavis
Copy link
Member

Thank you!

AlexanderBrevig pushed a commit to AlexanderBrevig/helix that referenced this pull request Aug 29, 2022
@ath3 @AlexanderBrevig
AWK support (helix-editor#3528)
771cbe8
thomasskk pushed a commit to thomasskk/helix that referenced this pull request Sep 9, 2022
@ath3 @thomasskk
AWK support (helix-editor#3528)
2774103
jdrst pushed a commit to jdrst/helix that referenced this pull request Sep 13, 2022
@ath3 @jdrst
AWK support (helix-editor#3528)
b7baca8
@David-Else
Copy link
Contributor

@ath3 could you add install instructions to https://github.com/helix-editor/helix/wiki/How-to-install-the-default-language-servers ?

@ath3
Copy link
Contributor Author

ath3 commented Oct 16, 2022

@ath3 could you add install instructions to https://github.com/helix-editor/helix/wiki/How-to-install-the-default-language-servers ?

done!

@David-Else
Copy link
Contributor

@ath3 Nice one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ath3 @the-mikedavis @David-Else