packaging: Point to homebrew-core instead of tap #3513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should also deprecate the tap by opening a PR here: https://github.com/brewsci/homebrew-science/blob/master/tap_migrations.json |
|
The homebrew package should also remove grammar sources. |
Just upstreamed this in Homebrew/homebrew-core#108657 👍 For deprecating the tap, do you mean to create a |
|
No, looks like taps use a centralized |
|
I think those are only for the formulas that were packaged in that tap |
thomasskk
pushed a commit
to thomasskk/helix
that referenced
this pull request
Sep 9, 2022
jdrst
pushed a commit
to jdrst/helix
that referenced
this pull request
Sep 13, 2022
herkhinah
pushed a commit
to herkhinah/helix
that referenced
this pull request
Dec 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that helix is packaged in homebrew-core, I don't think it's necessary to run the tap anymore.
It's difficult to install a formula from a tap because core has higher precedence than taps: you need to first tap helix
brew tap helix-editor/homebrew-helixand thenbrew install helix-editor/homebrew-helix/helix(https://docs.brew.sh/Taps#formula-with-duplicate-names).