-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce storage highlighting for typescript/javascript #2961
Conversation
Could you add some docs on the new keys? Line 154 in e58d28a
|
All done. Feedback on the changes are welcome. I've slightly moved around the existing storage description as it was more specific to the modifier sub-scope. I've added example keywords in rust as that was what was already there, however my personal opinion is that we shouldn't provide language specific examples. For a start I think those keywords are probably not implemented in the rust highlighting query. I'm also not a rust dev so please let me know if I've misunderstood some of the keywords and they don't fall into the categories I've described. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keyword.storage
was originally based on Vim's StorageClass
highlight group (#2731). I think textmate's use of storage.{type,modifier}
is a bit clearer though so let's lean towards those. For consistency though, Rust's const
should become keyword.storage.type
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
Inspired by and following the patterns of #2731.
Adds
keyword.storage.type
andkeyword.storage.modifier
scopes for syntax highlighting.