simplify some keymap key names #2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archseer
reviewed
Jun 6, 2022
Comment on lines
+370
to
+375
| fn parsing_unsupported_named_keys() { | ||
| assert!(str::parse::<KeyEvent>("lt").is_err()); | ||
| assert!(str::parse::<KeyEvent>("gt").is_err()); | ||
| assert!(str::parse::<KeyEvent>("plus").is_err()); | ||
| assert!(str::parse::<KeyEvent>("percent").is_err()); | ||
| assert!(str::parse::<KeyEvent>("semicolon").is_err()); |
There was a problem hiding this comment.
Rather than just testing these keys are now unsupported, shouldn't we also test that they get parsed correctly by the new syntax?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2369
Removed some of the existing named keys and added tests. Please let me know if there is anything more that I can do.