-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude cursor when doing ctrl-w #2431
Conversation
Currently ctrl-w in insert mode deletes the cursor which results in unexpected behavior. The patch also reduces the selection to cursor before performing prev word to remove the behavior of removing unnecessary text when nothing should be removed. 1. `::#(|)#::` after `ctrl-w` should be `#(|)#::`, previously `#(|)#:` 2. `#(|::)#` after `ctrl-w` should be `#(|::)#`, previously `#(|)#` Fix helix-editor#2390
Thank you @pickfire !! I have noticed this but had not gotten around to the fix 🚀 🚀 🚀 |
I just realized there is a bug on this, first insert
Then go to EOF (spam |
Hmm, I can't reproduce that I'm on
When I insert
then spam |
I can reproduce it, but I think I see why you can't: @pickfire and I are doing but it sounds like you're doing: |
@scgtrp Thanks for making it more accurate, I forgot to say delete one newline character using backspace on insert mode. Oh, seemed like if the newline was deleted from normal mode and insert mode both have the same result.
|
Currently ctrl-w in insert mode deletes the cursor which results in unexpected behavior. The patch also reduces the selection to cursor before performing prev word to remove the behavior of removing unnecessary text when nothing should be removed. 1. `::#(|)#::` after `ctrl-w` should be `#(|)#::`, previously `#(|)#:` 2. `#(|::)#` after `ctrl-w` should be `#(|::)#`, previously `#(|)#` Fix helix-editor#2390
Currently ctrl-w in insert mode deletes the cursor which results in unexpected behavior. The patch also reduces the selection to cursor before performing prev word to remove the behavior of removing unnecessary text when nothing should be removed. 1. `::#(|)#::` after `ctrl-w` should be `#(|)#::`, previously `#(|)#:` 2. `#(|::)#` after `ctrl-w` should be `#(|::)#`, previously `#(|)#` Fix helix-editor#2390
Currently ctrl-w in insert mode deletes the cursor which results in
unexpected behavior. The patch also reduces the selection to cursor before
performing prev word to remove the behavior of removing unnecessary text
when nothing should be removed.
::#(|)#::
afterctrl-w
should be#(|)#::
, previously#(|)#:
#(|::)#
afterctrl-w
should be#(|::)#
, previously#(|)#
Fix #2390
cc @scgtrp thanks for reporting the issue
Would be good if @cessen can review, I wonder if there is a better solution for this