feat(languages): git-ignore and git-attributes #2397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweet! Would you mind adding a license to tree-sitter-gitattributes? I think technically we're not supposed to distribute grammar repositories without a license that says we can. I also opened up shunsambongi/tree-sitter-gitignore#1 for the gitignore grammar. And yep, that regex change for the inherits looks good 👍 |
|
Looks like tree-sitter-gitignore has a license now 🎉. If you update the revision for that grammar I think this should be good to merge. |
Great, 5fee71f includes the versions of both grammars with licenses! |
the-mikedavis
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
.gitignoreand.gitattributesfiles. I was a little unsure of where to include dashes in the name/scope/injection regex, but I tried to be consistent with the othergit-*filetypes. There's no indent values specified since these filetypes don't have indentation. I had to make one change to the core code to allow for hyphens in; inherits: ...comments, hope that's ok. Finally, using non-hyphenated grammar names seemed to be necessary, otherwise the grammars just don't work, but I'm not sure why...