Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): divide hcl into seperate languages #2244

Merged
merged 3 commits into from
Apr 23, 2022
Merged

fix(lsp): divide hcl into seperate languages #2244

merged 3 commits into from
Apr 23, 2022

Conversation

hown3d
Copy link
Contributor

@hown3d hown3d commented Apr 23, 2022

Terraform-ls uses two seperate language-ids for terraform and terraform-vars files.

Read more about it here

the-mikedavis
the-mikedavis requested changes Apr 23, 2022
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little duplication nit, otherwise I think this is good 👍

languages.toml Outdated Show resolved Hide resolved
the-mikedavis
the-mikedavis approved these changes Apr 23, 2022
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@the-mikedavis the-mikedavis merged commit 5ca8dfe into helix-editor:master Apr 23, 2022
@hown3d hown3d deleted the hcl-lsp branch April 23, 2022 22:20
@dxmh dxmh mentioned this pull request Jan 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hown3d @the-mikedavis