Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dracula at night theme #2008

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Add dracula at night theme #2008

merged 2 commits into from
Apr 8, 2022

Conversation

samsartor
Copy link
Contributor

Super simple. I just like a darker background lol

the-mikedavis
the-mikedavis approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice! I'm a fan of the higher contrast 🎨

@the-mikedavis
Copy link
Member

The file name has dashes instead of underscores; it looks like we've mostly used underscores but there are exceptions. The inconsistency doesn't really bother me - do others have opinions on this? Should we prefer one or the other?

@the-mikedavis
Copy link
Member

Don't forget to add this to the themes wiki once merged! https://github.com/helix-editor/helix/wiki/Themes

@David-Else
Copy link
Contributor

The file name has dashes instead of underscores; it looks like we've mostly used underscores but there are exceptions. The inconsistency doesn't really bother me - do others have opinions on this? Should we prefer one or the other?

They should all be underscores, it could be triggering for programmers to encounter the aberration of inconsistent file naming.

@the-mikedavis
Copy link
Member

Just wait until I make a theme with a non-breaking whitespace character :P

@the-mikedavis the-mikedavis merged commit 209ec44 into helix-editor:master Apr 8, 2022
@the-mikedavis the-mikedavis mentioned this pull request May 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsartor @the-mikedavis @David-Else