Send active diagnostics to LSP when requesting code actions. #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for e.g. clangd to properly send the quickfix code actions corresponding to those diagnostics as options. The LSP spec v3.16.0 introduced an opaque `data` member that would allow the server to persist arbitrary data between the diagnostic and the code actions request, but this is not supported yet by this commit.
archseer
requested changes
Apr 13, 2022
helix-lsp/src/lib.rs
Outdated
Comment on lines
80
to
83
| lsp::Range::new( | ||
| pos_to_lsp_pos(doc, diag.range.start, offset_encoding), | ||
| pos_to_lsp_pos(doc, diag.range.end, offset_encoding), | ||
| ), |
There was a problem hiding this comment.
There was a problem hiding this comment.
That takes a helix_core::selection::Range whereas the diagnostics have their own helix_core::diagnostic::Range.
So either this was an option, or you'd need to construct the regular Range first.
archseer
approved these changes
Apr 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for e.g. clangd to properly send the quickfix code actions corresponding to those diagnostics as options.
The LSP spec v3.16.0 introduced an opaque
datamember that would allow the server to persist arbitrary data between the diagnostic and the code actions request, but this is not supported yet by this commit.