Fix ctrl-u on insert behavior #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now should follow vim behavior more - no longer remove text on cursor - no longer remove selected text while inserting - first kill to start non-whitespace, start, previous new line
archseer
reviewed
Apr 12, 2022
helix-term/src/commands.rs
Outdated
Comment on lines
684
to
694
| let head = if anchor == first_char && line != 0 { | ||
| line_end_char_index(&text, line - 1) | ||
| } else if let Some(pos) = find_first_non_whitespace_char(text.line(line)) { | ||
| if first_char + pos < anchor { | ||
| first_char + pos | ||
| } else { | ||
| first_char | ||
| } | ||
| } else { | ||
| first_char | ||
| }; |
There was a problem hiding this comment.
This whole block has no comments and is kind of hard for me to understand what it's doing.
There was a problem hiding this comment.
Sorry, I thought it was clear enough, added comments now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now should follow vim behavior more