Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typed commands buffer-next and buffer-previous #1940

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions book/src/generated/typable-cmd.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
| `:buffer-close-others!`, `:bco!`, `:bcloseother!` | Close all buffers but the currently focused one. |
| `:buffer-close-all`, `:bca`, `:bcloseall` | Close all buffers, without quiting. |
| `:buffer-close-all!`, `:bca!`, `:bcloseall!` | Close all buffers forcefully (ignoring unsaved changes), without quiting. |
| `:buffer-next`, `:bn`, `:bnext` | Go to next buffer. |
| `:buffer-previous`, `:bp`, `:bprev` | Go to previous buffer. |
| `:write`, `:w` | Write changes to disk. Accepts an optional path (:write some/path.txt) |
| `:new`, `:n` | Create a new scratch buffer. |
| `:format`, `:fmt` | Format the file using the LSP formatter. |
Expand Down
19 changes: 9 additions & 10 deletions helix-term/src/commands.rs
Original file line number Diff line number Diff line change
Expand Up @@ -637,36 +637,35 @@ fn goto_line_start(cx: &mut Context) {
}

fn goto_next_buffer(cx: &mut Context) {
goto_buffer(cx, Direction::Forward);
goto_buffer(cx.editor, Direction::Forward);
}

fn goto_previous_buffer(cx: &mut Context) {
goto_buffer(cx, Direction::Backward);
goto_buffer(cx.editor, Direction::Backward);
}

fn goto_buffer(cx: &mut Context, direction: Direction) {
let current = view!(cx.editor).doc;
fn goto_buffer(editor: &mut Editor, direction: Direction) {
let current = view!(editor).doc;

let id = match direction {
Direction::Forward => {
let iter = cx.editor.documents.keys();
let iter = editor.documents.keys();
let mut iter = iter.skip_while(|id| *id != &current);
iter.next(); // skip current item
iter.next().or_else(|| cx.editor.documents.keys().next())
iter.next().or_else(|| editor.documents.keys().next())
}
Direction::Backward => {
let iter = cx.editor.documents.keys();
let iter = editor.documents.keys();
let mut iter = iter.rev().skip_while(|id| *id != &current);
iter.next(); // skip current item
iter.next()
.or_else(|| cx.editor.documents.keys().rev().next())
iter.next().or_else(|| editor.documents.keys().rev().next())
}
}
.unwrap();

let id = *id;

cx.editor.switch(id, Action::Replace);
editor.switch(id, Action::Replace);
}

fn extend_to_line_start(cx: &mut Context) {
Expand Down
32 changes: 32 additions & 0 deletions helix-term/src/commands/typed.rs
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,24 @@ fn force_buffer_close_all(
buffer_close_by_ids_impl(cx.editor, &document_ids, true)
}

fn buffer_next(
cx: &mut compositor::Context,
_args: &[Cow<str>],
_event: PromptEvent,
) -> anyhow::Result<()> {
goto_buffer(cx.editor, Direction::Forward);
Ok(())
}

fn buffer_previous(
cx: &mut compositor::Context,
_args: &[Cow<str>],
_event: PromptEvent,
) -> anyhow::Result<()> {
goto_buffer(cx.editor, Direction::Backward);
Ok(())
}

fn write_impl(cx: &mut compositor::Context, path: Option<&Cow<str>>) -> anyhow::Result<()> {
let jobs = &mut cx.jobs;
let doc = doc_mut!(cx.editor);
Expand Down Expand Up @@ -1082,6 +1100,20 @@ pub const TYPABLE_COMMAND_LIST: &[TypableCommand] = &[
fun: force_buffer_close_all,
completer: None,
},
TypableCommand {
name: "buffer-next",
aliases: &["bn", "bnext"],
doc: "Go to next buffer.",
fun: buffer_next,
completer: None,
},
TypableCommand {
name: "buffer-previous",
aliases: &["bp", "bprev"],
doc: "Go to previous buffer.",
fun: buffer_previous,
completer: None,
},
TypableCommand {
name: "write",
aliases: &["w"],
Expand Down