theme: Enable style modifiers in theme.toml

[intarga]

Support for configuring style modifiers like bold, italic, etc. in theme.toml. They're done as an array, alongside fg and bg.

[intarga]

Seems to work. Going to write some documentation for theme.toml.

[archseer]

(Sorry, tapped the wrong button, meant to approve the CI run but it got unmarked as a draft)

[archseer]

This looks pretty good! Would you mind adding a short test for it? I know theme.rs doesn't contain any tests yet, but I think it would be useful to get some coverage

[intarga]

Perhaps we can add a contrib/themes directory for user submitted themes? Or make a separate repo for themes under helix-editor and link to it in the docs?

[intarga]

This looks pretty good! Would you mind adding a short test for it? I know theme.rs doesn't contain any tests yet, but I think it would be useful to get some coverage

Are these what you had in mind?

[archseer]

Yep, that looks fine! I'll accept a contrib/themes directory too if you want to add your theme?

[pickfire]

Nice, there are tests and the code is better. The theme looks nice too.

Just wondering where you get inspiration for this theme?

[intarga]

Just wondering where you get inspiration for this theme?

The colours mostly came from here: https://github.com/alnj/dotfiles
I use it as my terminal theme, and I just tried to get helix looking as close as I could to the neovim setup I'm used too.

[pickfire]

Everything looks good to me except the toml key thing. I think rust version looks nicer. See what @archseer say.

[archseer]

I think bare keys are preferred, I just quoted all of my keys originally when I was porting my theme over. It's worth mentioning that key names with . need quoting though, or people will run into issues with their rule not being applied

[archseer]

Sidenote: @pickfire should we simply re-export log from helix_core?

[pickfire]

I don't think it's necessary. We can just do this, it seemed better. For log it's easy to keep them in sync.

[pickfire]

I think bare keys are preferred, I just quoted all of my keys originally when I was porting my theme over. It's worth mentioning that key names with . need quoting though, or people will run into issues with their rule not being applied

I think we can do something like the following for those with . right?

[ui]
bg = ...

[archseer]

No, it needs to be a top level string key:

{ "ui.menu" = <>} vs { ui = { menu = <>}}

Not quoting the key will result in a nested map and won't work correctly

[pickfire]

Nice, there are tests and the code is better. The theme looks nice too.

Just wondering where you get inspiration for this theme? I think this might get others confused why their stuff didn't get applied if they forgot to do the "x.x" quote.

[archseer]

Great work on this, especially the documentation part and congrats on being the first to contribute a theme! 🎉