Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing ) and ( to cycle the primary selection forward and backward through selections doesn't work #6080

Closed
milvi opened this issue Feb 22, 2023 · 2 comments
Labels
C-bug Category: This is a bug R-duplicate Duplicated issue: please refer to the linked issue

Comments

@milvi
Copy link

milvi commented Feb 22, 2023

Summary

Typing ) and ( to cycle the primary selection forward and backward
through selections is broken.

Reproduction Steps

I tried this:

  1. hx :tutor and followed the steps mentioned :
    ======================================================
    = 9.2 ADDING SELECTION ON NEXT SEARCH MATCH =
    ======================================================

Type ) and ( to cycle the primary selection forward and backward
through selections respectively.

Press Alt-, to remove the primary selection.

  1. Move the cursor to the line marked '-->' below.
  2. Select both lines with xx or 2x.
  3. Type s to select, type "would" and enter.
  4. Use ( and ) to cycle the primary selection and remove the
    very second "would" with Alt-, .
  5. Type c "wood" to change the remaining "would"s to "wood".

--> How much would would a wouldchuck chuck
--> if a wouldchuck could chuck would?

I expected this to happen: Cycling through selections.

Instead, this happened: Nothing.

Helix log

~/.cache/helix/helix.log
2023-02-22T16:46:21.550 helix_loader [DEBUG] Located configuration folders: []
2023-02-22T16:46:21.556 helix_view::clipboard [DEBUG] Using xclip to interact with the system and selection (primary) clipboard
2023-02-22T16:46:21.556 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2023-02-22T16:46:21.957 helix_term::application [DEBUG] received editor event: IdleTimer
2023-02-22T16:46:22.427 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2023-02-22T16:46:22.715 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2023-02-22T16:46:22.811 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2023-02-22T16:46:22.829 helix_term::application [DEBUG] received editor event: IdleTimer
2023-02-22T16:46:22.907 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2023-02-22T16:46:23.019 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2023-02-22T16:46:23.147 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2023-02-22T16:46:23.420 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2023-02-22T16:46:23.420 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:25.067 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:25.468 helix_term::application [DEBUG] received editor event: IdleTimer
2023-02-22T16:46:25.612 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:25.740 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:25.820 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:25.980 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:26.364 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:26.444 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:26.620 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:27.244 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:27.468 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:27.869 helix_term::application [DEBUG] received editor event: IdleTimer
2023-02-22T16:46:30.854 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:30.880 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:30.912 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:30.944 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:31.062 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:31.430 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:31.462 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:31.556 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:32.132 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:32.975 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:34.077 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:34.126 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:34.411 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:34.587 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:34.989 helix_term::application [DEBUG] received editor event: IdleTimer
2023-02-22T16:46:38.603 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:38.923 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:39.005 helix_term::application [DEBUG] received editor event: IdleTimer
2023-02-22T16:46:39.035 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:39.099 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:39.292 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:39.403 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:39.803 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:41.803 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:42.091 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:42.267 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:42.427 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:42.828 helix_term::application [DEBUG] received editor event: IdleTimer
2023-02-22T16:46:42.987 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:43.244 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:43.435 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:43.611 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:43.755 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:44.155 helix_term::application [DEBUG] received editor event: IdleTimer
2023-02-22T16:46:44.315 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:44.619 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:45.019 helix_term::application [DEBUG] received editor event: IdleTimer
2023-02-22T16:46:45.147 helix_term::commands::typed [DEBUG] quitting...
2023-02-22T16:46:45.147 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:45.531 helix_view::document [DEBUG] id 2 modified - last saved: 0, current: 0
2023-02-22T16:46:46.299 helix_term::job [DEBUG] waiting on jobs...
2023-02-22T16:46:46.299 helix_term::job [DEBUG] waiting on jobs...

Platform

Linux 5.15.0-58-generic #64-Ubuntu SMP Thu Jan 5 11:43:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Terminal Emulator

gnome-terminal

Helix Version

22.12-293-g80439592

@milvi milvi added the C-bug Category: This is a bug label Feb 22, 2023
@the-mikedavis
Copy link
Member

Which theme are you using? This might be #3842 (#3842 (comment))

@milvi
Copy link
Author

milvi commented Feb 22, 2023

Indeed ! I was using acme with which there is no telling that cycling effects since there is no color differentiation.

However, the default theme has the same issue albeit the line over which cycling occurs has a different highlight. On a line though, selections remain uniformly displayed in the same color. Consequently, there 's no telling where cycling is at.

This is #3842 (comment) and #3842 (comment) offers an insight through tweaking theme configs.

Note : I believe that the default theme should reflect a change that provides a feedback of the cycling behavior to the user. A newbie (like myself) can't follow the :tutor guide explaining basic features without being left perplexed.

@the-mikedavis the-mikedavis closed this as not planned Won't fix, can't repro, duplicate, stale Feb 22, 2023
@the-mikedavis the-mikedavis added the R-duplicate Duplicated issue: please refer to the linked issue label Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug R-duplicate Duplicated issue: please refer to the linked issue
Projects
None yet
Development

No branches or pull requests

2 participants