Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug with default theme color ui.selection.primary same as ui.selection #5314

Closed
goyalyashpal opened this issue Dec 27, 2022 · 2 comments
Closed

bug with default theme color ui.selection.primary same as ui.selection #5314

goyalyashpal opened this issue Dec 27, 2022 · 2 comments
Labels
R-duplicate Duplicated issue: please refer to the linked issue

Comments

@goyalyashpal
Copy link
Contributor

goyalyashpal commented Dec 27, 2022 •
edited
Loading

bug with default theme color ui.selection.primary same as ui.selection

just tested on hx v22.05, and I'd say that this is a bug indeed with the default theme.

Originally posted by @yashpalgoyal1304 in #5309 (comment)
goyalyashpal added a commit to goyalyashpal/helix that referenced this issue Dec 27, 2022
@goyalyashpal
Change primary selection color...
1278ee7 
Fix helix-editor#5314
in continuation of helix-editor#5309
@goyalyashpal goyalyashpal mentioned this issue Dec 27, 2022
Closed
goyalyashpal added a commit to goyalyashpal/helix that referenced this issue Dec 27, 2022
@goyalyashpal
theme: Differentiate selection primary color ...
4643af8 
Fix helix-editor#5314
In continuation of helix-editor#5309
@kirawi
Copy link
Member

kirawi commented Dec 27, 2022

Duplicate of #3842

@kirawi kirawi marked this as a duplicate of #3842 Dec 27, 2022
@kirawi kirawi closed this as not planned Won't fix, can't repro, duplicate, stale Dec 27, 2022
@kirawi kirawi added the R-duplicate Duplicated issue: please refer to the linked issue label Dec 27, 2022
@goyalyashpal
Copy link
Contributor Author

goyalyashpal commented Dec 27, 2022 •
edited
Loading

hi @kirawi
thanks for linking to the above issue. umh, so, will u reject the pr as well? 😅

umh, this issue can be considered to be worthwhile to stay open as this is for the default theme,
while the linked one refers to themes in general.

also refer to the pr linked in the description

With default theme, one expects it to be good enough for different distinctions, whereas when using a different theme, it's given that it may not be a proper one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
R-duplicate Duplicated issue: please refer to the linked issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change primary selection color... goyalyashpal/helix
2 participants
@goyalyashpal @kirawi