Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme monokai_pro_spectrum uses an unnamed orange color. Should the existing orange be used? #5251

Open
LeoniePhiline opened this issue Dec 21, 2022 · 3 comments
Labels
A-theme Area: Theme and appearence related C-enhancement Category: Improvements

Comments

@LeoniePhiline
Copy link
Contributor

LeoniePhiline commented Dec 21, 2022

Summary

The theme monokai_pro_spectrum uses an unnamed color #f59762 which is slightly lighter than the named orange (#fd9353):

image
image

I would provide a PR but need to ask first:

Should orange be used, or should the unnamed light orange be named and added to the palette?

Reproduction Steps

No response

Helix log

No response

Platform

openSUSE Tumbleweed - Linux

Terminal Emulator

Konsole

Helix Version

helix 22.12

@LeoniePhiline LeoniePhiline added the C-bug Category: This is a bug label Dec 21, 2022
@the-mikedavis the-mikedavis added the A-theme Area: Theme and appearence related label Dec 21, 2022
@the-mikedavis
Copy link
Member

\cc @WindSoilder what do you think for this color?

@WindSoilder
Copy link
Contributor

Hi, after searching in original theme: https://github.com/subtheme-dev/monokai-pro/search?q=f59762

I found that the color is used for file status, but orange color is used for file status too: https://github.com/subtheme-dev/monokai-pro/search?q=orange

So I'd agree with @LeoniePhiline , we can use orange color instead of the un-named color

@LeoniePhiline
Copy link
Contributor Author

If it adds context, then it could be better to just give it an appropriate name and keep the color?

@pascalkuthe pascalkuthe added C-enhancement Category: Improvements and removed C-bug Category: This is a bug labels Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

4 participants