Gruvbox theme has disorienting palette for selected regions

[kronodeus]

Top part of the screenshot above is the OOTB Gruvbox theme. As you can see, it's quite offensive to the eyes and makes it hard to see exactly where the selected region begins and ends at a glance. The bottom part of the screenshot is the theme after a couple tweaks to the palette.

Not sure if anyone actually prefers the way it is now, but it seems untenable to me.

Here's the modified settings from the screenshot:

"ui.selection" = { bg = "bg2" }
"ui.cursor.primary" = { bg = "fg4", fg = "bg1" }
"ui.cursor.match" = { bg = "bg3" }

Opened a pull request for the same here: #4626

[the-mikedavis]

Closed in #4626