Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ syntax highlighting incorrectly coloring std functions #3788

Closed
LeadFreeCandy opened this issue Sep 10, 2022 · 2 comments · Fixed by #4079
Closed

C++ syntax highlighting incorrectly coloring std functions #3788

LeadFreeCandy opened this issue Sep 10, 2022 · 2 comments · Fixed by #4079
Labels
A-tree-sitter Area: Tree-sitter C-bug Category: This is a bug

Comments

@LeadFreeCandy
Copy link

Summary

When you modify the existing "onedark" theme to highlight variables as red, it incorrectly highlighted std functions as variables as well.

In the default "onedark" theme the code looks like this:
Screen Shot 2022-09-10 at 7 14 29 PM

Which is not actually true to what it should look like, as in atom variables are red. When you change the variables attribute in the theme file it looks like this:
Screen Shot 2022-09-10 at 7 14 10 PM

The variables are now correctly highlighted red, but std::getline() and std::tolower() are now erroneously colored. They should be highlighted blue but they are not detected as functions.

Reproduction Steps

No response

Helix log

No response

Platform

macOS

Terminal Emulator

iTerm2

Helix Version

Helix 22.08.1

@LeadFreeCandy LeadFreeCandy added the C-bug Category: This is a bug label Sep 10, 2022
@kirawi
Copy link
Member

kirawi commented Sep 11, 2022

Does #3789 resolve this? Variable highlights will be less accurate though.

@LeadFreeCandy
Copy link
Author

Just built it from your commit and no, it does not fix it unfortunately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tree-sitter Area: Tree-sitter C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants