-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect path passing for LSP server #256
Comments
I think this is a rust-analyzer issue: rust-lang/rust-analyzer#1798 We try to detect a |
It's not just rust-analyzer, as rls failed with the same issue. I have |
Yeah currently we don't consume those roots yet. I think we need to change find_roots to accept a Lines 42 to 46 in 1bda454
The reason I haven't done this yet is because I don't know what the behavior should be here. If we stop at the first parent dir with a |
I think if we look at |
$HOME doesn't contain |
I used to have it until it broke some applications so I use an alias |
Perhaps, at least for rust, we could search for a directory containing both a |
Perhaps for rust-only projects. In my original example it's not the case
To me it seems the proper solution is actually reading the if additional verification is wanted, then of course it's possible to check that the |
nvim-lsp uses |
Since both are rust projects, perhaps we could just steal some of the code |
Is this still an issue since the assert seems to have been changed on master? |
I think this is still an issue, and not just for Julia but any mono-repo. Our structure looks like this
I think (as mentioned above) the issue is with the Line 41 in 3156577
If I understand it correctly, ideally this call to |
I think the procedure should be:
|
I opened #1370 with a slightly different logic (stop looking for markers when reaching git repo boundary, but not sure it makes more sense) |
Resolved by #1370 |
Reproduction steps
/home/to266/projects/funny/some/folder/workspace/funny
. Ifworkspace
literally corresponds to rust workspace, andfunny
inside is a rust package withing the workspace.hx
insidefunny
the packageEnvironment
The text was updated successfully, but these errors were encountered: