Jumping backward: 'called Option::unwrap() on a None value'

[CBenoit]

Summary

I got a panic due to an Option which was None when it was expected to be Some while jumping backward.

Reproduction Steps

I'm not sure. I was navigating helix codebase and got this panic when I jumped backward a few times.

thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', helix-term/src/commands.rs:3756:27
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Helix log

No response

Platform

Linux

Terminal Emulator

alacritty 0.11.0-dev

Helix Version

helix-term 22.05-dev (0eb8799)

[CptPotato]

I think I got a similar crash when using the jumplist after closing a split/buffer. Was this the case for you as well, or did you just jump back?

[CBenoit]

I might have closed a buffer, but I don't remember exactly. Following the crash, I tried to reproduce by closing a buffer, but the jump list appeared to be invalidated and I couldn't jump anymore.

[EpocSquadron]

I can also confirm I am encountering this from time to time, with some combination of opening and closing splits and buffers and using the jumplist. I've tried reproducing as well but haven't been able to nail it down either.

[archseer]

This indicates to me that the jumplist might point to a document that doesn't exist anymore: https://github.com/helix-editor/helix/blob/0eb87996a8e8245d7aa2688fc7397ed5a174e311/helix-term/src/commands.rs#L3756=

There was a fix being worked on in #1397 (comment) but the PR is unfinished.