Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Crystal language support #1679

Open
spindlebink opened this issue Feb 19, 2022 · 2 comments
Open

Add Crystal language support #1679

spindlebink opened this issue Feb 19, 2022 · 2 comments
Labels
A-language-support Area: Support for programming/text languages C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors E-help-wanted Call for participation: Extra attention is needed

Comments

@spindlebink
Copy link
Contributor

The built-in Ruby syntax works fine for Crystal files (I added a .cr file type to languages.toml) but there's already a Crystal tree-sitter on GitHub that I don't imagine would be too hard to add, providing somebody can write query files for it.

@spindlebink spindlebink added the C-enhancement Category: Improvements label Feb 19, 2022
@archseer archseer added E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors E-help-wanted Call for participation: Extra attention is needed labels Feb 19, 2022
@kirawi kirawi added the A-tree-sitter Area: Tree-sitter label Feb 19, 2022
@spindlebink
Copy link
Contributor Author

Alright, have taken a shot at writing the query for this, since Ruby's parser borks at the floored division operator //, and at a second look it seems that the linked implementation might not be complete. I know next to nothing about tree sitter implementations, though, so I could be mistaken--will probably need someone with expertise to check or possibly the author of the original repo @keidax to chime in.

@keidax
Copy link

keidax commented Feb 24, 2022

That's correct, tree-sitter-crystal is very much a work in progress. I'll add a README notice to make that clearer.

@kirawi kirawi added A-language-support Area: Support for programming/text languages and removed A-tree-sitter Area: Tree-sitter labels Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors E-help-wanted Call for participation: Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants