Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using ctrl + d to close a buffer from buffer picker by default #1593

Closed
Zaplae opened this issue Jan 27, 2022 · 8 comments
Closed

Allow using ctrl + d to close a buffer from buffer picker by default #1593

Zaplae opened this issue Jan 27, 2022 · 8 comments
Labels
A-keymap Area: Keymap and keybindings C-enhancement Category: Improvements

Comments

@Zaplae
Copy link

Zaplae commented Jan 27, 2022

ctrl + d is equals to :buffer_close, this is quick by input buffer_close
if you have unsaved buffer, you have to input :bufer_close! :)

@Zaplae
Copy link
Author

Zaplae commented Apr 22, 2022

Ok, I just did't know it's alias and now the display of aliases was fixed.
I'll close this issue.

@Zaplae Zaplae closed this as completed Apr 22, 2022
@the-mikedavis
Copy link
Member

Let's keep this open as a C-d or similar keymap in the buffer picker could be useful to quickly close a handful of buffers.

@mangas
Copy link
Contributor

mangas commented Jul 8, 2022

@sudormrfbin might be worth renaming the ticket as it looks like the purpose has changed?

@sudormrfbin
Copy link
Member

The title for this issue is referring to closing buffers from the buffer picker using a keybind and I think you opened a ticket with the same intent? If so the title matches since it's still about adding a keybind to the buffer list.

@mangas
Copy link
Contributor

mangas commented Jul 8, 2022

Yep you're right, I got a little confused with the alias related discussion above, nevermind!

@sudormrfbin sudormrfbin added E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors labels Sep 11, 2022
@kirawi kirawi assigned kirawi and unassigned kirawi Sep 22, 2022
@pickfire
Copy link
Contributor

If anything I think it is better to add shortcuts to space + b and have a shortcut key there to delete buffer, rather than having another popup created just to delete buffer.

@kirawi
Copy link
Member

kirawi commented Sep 23, 2022

I added a handle_key_events closure field to the Picker to have custom keys for each type of picker. It works, but I need to find a way to update the picker afterwards.

@pickfire
Copy link
Contributor

I think later on we need some kind of infobox mechanisms to make those keys discoverable.

@the-mikedavis the-mikedavis removed E-good-first-issue Call for participation: Issues suitable for new contributors E-easy Call for participation: Experience needed to fix: Easy / not much labels Aug 19, 2023
@helix-editor helix-editor locked and limited conversation to collaborators Apr 14, 2024
@pascalkuthe pascalkuthe converted this issue into discussion #10430 Apr 14, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
A-keymap Area: Keymap and keybindings C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants