Searching for \0 leaks error message into UI

[ashfield-kasku]

Summary

If you type /\0<ret> then this will happen:

I assume it's not intentional since it's black-on-black in the default theme.

Reproduction Steps

No response

Helix log

No response

Platform

Linux

Terminal Emulator

foot

Installation Method

source

Helix Version

24.07-52-gc34164c0

[the-mikedavis]

That is an instance of a popup component actually, it isn't leaking:

helix/helix-term/src/ui/mod.rs

Lines 136 to 160 in c9d829a

	Err(err) => {
	let (view, doc) = current!(cx.editor);
	doc.set_selection(view.id, snapshot.clone());
	view.offset = offset_snapshot;
	if event == PromptEvent::Validate {
	let callback = async move {
	let call: job::Callback = Callback::EditorCompositor(Box::new(
	move |_editor: &mut Editor, compositor: &mut Compositor| {
	let contents = Text::new(format!("{}", err));
	let size = compositor.size();
	let popup = Popup::new("invalid-regex", contents)
	.position(Some(helix_core::Position::new(
	size.height as usize - 2, // 2 = statusline + commandline
	0,
	)))
	.auto_close(true);
	compositor.replace_or_push("invalid-regex", popup);
	},
	));
	Ok(call)
	};
	cx.jobs.callback(callback);
	}

I believe this is a theme issue with the default theme or the Text component - it depends on which colors your terminal is using. For example with a dark terminal theme and the default Helix theme I see:

[ashfield-kasku]

Ah ok, that makes sense, I'm using a light theme.