Modals are not properly cleared when closed

[qti3e]

Summary

Hey everyone, great project!

I am facing a bug, where there are left-over characters from the modal/dialog border on the screen when I close the dialog. Doesn't matter if it's the command palette or the file picker.

I included some screenshots as well. Let me know if you need any other information about the system/terminal.

have an amazing day :)

Reproduction Steps

I tried this:

1. hx file.rs
2. open command pallete / ?
3. close it (enter)

I expected this to happen:
The modal/dialog to be closed without any lasting effect.

Instead, this happened:

Helix log

2022-12-12T05:23:33.442 helix_view::editor [ERROR] Failed to initialize the LSP for `source.rust` { cannot find binary path }
2022-12-12T05:25:32.425 helix_view::editor [ERROR] Failed to initialize the LSP for `source.rust` { cannot find binary path }
2022-12-12T05:27:43.610 helix_view::editor [ERROR] editor error: 1 unsaved buffer(s) remaining: ["core/src/properties.rs"]
2022-12-12T05:37:43.752 helix_view::editor [ERROR] editor error: 1 unsaved buffer(s) remaining: ["core/src/properties.rs"]
2022-12-12T05:44:11.990 helix_view::editor [ERROR] editor error: no last accessed buffer
2022-12-12T05:44:57.405 helix_view::editor [ERROR] editor error: 1 unsaved buffer(s) remaining: ["core/src/properties.rs"]
2022-12-12T05:45:35.208 helix_view::editor [ERROR] editor error: 1 unsaved buffer(s) remaining: ["core/src/properties.rs"]
2022-12-12T05:45:44.775 helix_view::editor [ERROR] editor error: 1 unsaved buffer(s) remaining: ["core/src/properties.rs"]
2022-12-12T05:47:41.529 helix_view::editor [ERROR] editor error: no such command: 'help'
2022-12-12T05:47:55.666 helix_view::editor [ERROR] editor error: no such command: 'help'
2022-12-12T05:51:13.053 helix_view::editor [ERROR] editor error: Is a directory (os error 21)
2022-12-12T05:54:52.293 helix_view::editor [ERROR] editor error: no such command: 'picker'
2022-12-12T05:54:55.380 helix_view::editor [ERROR] editor error: no such command: 'pick'
2022-12-12T05:54:59.283 helix_view::editor [ERROR] editor error: no such command: 'pick'
2022-12-12T05:55:06.211 helix_view::editor [ERROR] editor error: Register [@] empty
2022-12-12T05:58:10.212 helix_lsp::transport [ERROR] err <- "thread 'Worker' panicked at 'internal error: entered unreachable code: derive diagnostic on item without derive attribute', crates/hir/src/lib.rs:731:25\n"
2022-12-12T05:58:10.212 helix_lsp::transport [ERROR] err <- "stack backtrace:\n"
2022-12-12T05:58:10.234 helix_lsp::transport [ERROR] err <- "   0: rust_begin_unwind\n"
2022-12-12T05:58:10.234 helix_lsp::transport [ERROR] err <- "             at /rustc/897e37553bba8b42751c67658967889d11ecd120/library/std/src/panicking.rs:584:5\n"
2022-12-12T05:58:10.235 helix_lsp::transport [ERROR] err <- "   1: core::panicking::panic_fmt\n"
2022-12-12T05:58:10.235 helix_lsp::transport [ERROR] err <- "             at /rustc/897e37553bba8b42751c67658967889d11ecd120/library/core/src/panicking.rs:142:14\n"
2022-12-12T05:58:10.235 helix_lsp::transport [ERROR] err <- "   2: core::panicking::unreachable_display\n"
2022-12-12T05:58:10.235 helix_lsp::transport [ERROR] err <- "   3: hir::emit_def_diagnostic\n"
2022-12-12T05:58:10.235 helix_lsp::transport [ERROR] err <- "   4: hir::Module::diagnostics\n"
2022-12-12T05:58:10.235 helix_lsp::transport [ERROR] err <- "   5: ide_diagnostics::diagnostics\n"
2022-12-12T05:58:10.235 helix_lsp::transport [ERROR] err <- "   6: std::panicking::try\n"
2022-12-12T05:58:10.235 helix_lsp::transport [ERROR] err <- "   7: ide::Analysis::diagnostics\n"
2022-12-12T05:58:10.235 helix_lsp::transport [ERROR] err <- "   8: rust_analyzer::handlers::publish_diagnostics\n"
2022-12-12T05:58:10.235 helix_lsp::transport [ERROR] err <- "   9: alloc::vec::in_place_collect::<impl alloc::vec::spec_from_iter::SpecFromIter<T,I> for alloc::vec::Vec<T>>::from_iter\n"
2022-12-12T05:58:10.235 helix_lsp::transport [ERROR] err <- "  10: <F as threadpool::FnBox>::call_box\n"
2022-12-12T05:58:10.235 helix_lsp::transport [ERROR] err <- "note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.\n"
2022-12-12T06:01:11.039 helix_view::editor [ERROR] editor error: Surround pair not found around all cursors
2022-12-12T06:01:14.627 helix_view::editor [ERROR] editor error: Cursor on ambiguous surround pair
2022-12-12T06:01:21.189 helix_view::editor [ERROR] editor error: Surround pair not found around all cursors
2022-12-12T06:02:38.999 helix_view::editor [ERROR] editor error: no such command: 'Ex'
2022-12-12T06:02:41.864 helix_view::editor [ERROR] editor error: no such command: 'ex'
2022-12-12T06:02:46.595 helix_view::editor [ERROR] editor error: 1 unsaved buffer(s) remaining: ["core/src/properties.rs"]
2022-12-12T06:03:46.943 helix_view::editor [ERROR] editor error: no such command: 'file_picker'
2022-12-12T06:03:52.753 helix_view::editor [ERROR] editor error: wrong argument count
2022-12-12T06:03:56.743 helix_view::editor [ERROR] editor error: Is a directory (os error 21)
2022-12-12T06:06:06.860 helix_view::editor [ERROR] editor error: Is a directory (os error 21)
2022-12-12T06:06:36.489 helix_view::editor [ERROR] Failed to initialize the LSP for `source.toml` { cannot find binary path }
2022-12-12T06:07:23.360 helix_term::commands [ERROR] Shell error: sh: 1: command not found

2022-12-12T06:07:23.360 helix_view::editor [ERROR] editor error: Shell error: sh: 1: command not found

2022-12-12T06:10:25.724 helix_view::editor [ERROR] editor error: no such command: 'clear'
2022-12-12T06:10:50.059 helix_view::editor [ERROR] editor error: no such command: 'redraw'
2022-12-12T06:13:44.233 helix_view::editor [ERROR] editor error: 1 unsaved buffer(s) remaining: ["core/src/properties.rs"]

Platform

macOS

Terminal Emulator

iTerm 2 / zsh

Helix Version

0b96021