This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
Save data upon state enters #313
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oc_restarts counter not being written to state file
andymck
changed the base branch from
master
to
andymck/poc-enable-targeting-restarts
|
Are we relying on the fact that we don't alter the Data except when transitioning between states? |
|
Data is always saved when transitioning state but we dont rely on altering/saving Data only at that point. There are a number of cases where we are altering and saving Data without transitioning state |
andymck
force-pushed
the
andymck/poc-enable-targeting-restarts
branch
from
691460e to
e5d7992
Compare
andymck
force-pushed
the
andymck/poc-enable-targeting-restarts
branch
from
e5d7992 to
9d3396f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: IGNORE THIS PR UNTIL AFTER #309 is MERGED