Skip to content
This repository was archived by the owner on Jun 12, 2023. It is now read-only.

add exp backoff to grpc client reconnects to vals #1839

Merged
merged 3 commits into from
Oct 28, 2022

Conversation

andymck
Copy link
Contributor

@andymck andymck commented Oct 26, 2022

Adds exponential backoff to reconnects to validators. The reconnects will start at 5 sec intervals and with each attempt expodentially increase up to a max of 180 secs. Reconnects include jitter

@andymck andymck force-pushed the andymck/add-exp-backoff branch 3 times, most recently from f5256ce to 7d6db9f Compare October 26, 2022 14:35
@andymck andymck marked this pull request as ready for review October 26, 2022 14:36
@Vagabond
Copy link
Contributor

Shouldn't we increase the backoff if the MAX_BLOCK_AGE is too high, as well?

@andymck
Copy link
Contributor Author

andymck commented Oct 26, 2022

Shouldn't we increase the backoff if the MAX_BLOCK_AGE is too high, as well?

if the max block age is exceeded, the statem will reenter the setup state and thus we will hit the backoff

@Vagabond
Copy link
Contributor

Shouldn't we increase the backoff if the MAX_BLOCK_AGE is too high, as well?

if the max block age is exceeded, the statem will reenter the setup state and thus we will hit the backoff

ok, this is what I figured.

@andymck andymck force-pushed the andymck/add-exp-backoff branch from b3e3c3c to 991c206 Compare October 27, 2022 16:20
@andymck andymck force-pushed the andymck/add-exp-backoff branch from 991c206 to 1c0d9c0 Compare October 27, 2022 16:29
@andymck andymck force-pushed the andymck/add-exp-backoff branch from 1ac4245 to 49eab0a Compare October 27, 2022 18:17
Co-authored-by: Abhay Kumar <75+abhay@users.noreply.github.com>
@madninja madninja merged commit 9fbd009 into master Oct 28, 2022
@madninja madninja deleted the andymck/add-exp-backoff branch October 28, 2022 11:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants