This repository was archived by the owner on Jun 12, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 254
add exp backoff to grpc client reconnects to vals #1839
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f5256ce
to
7d6db9f
Compare
Vagabond
reviewed
Oct 26, 2022
Shouldn't we increase the backoff if the MAX_BLOCK_AGE is too high, as well? |
if the max block age is exceeded, the statem will reenter the setup state and thus we will hit the backoff |
ok, this is what I figured. |
xandkar
reviewed
Oct 27, 2022
jeffgrunewald
approved these changes
Oct 27, 2022
b3e3c3c
to
991c206
Compare
jeffgrunewald
approved these changes
Oct 27, 2022
991c206
to
1c0d9c0
Compare
1ac4245
to
49eab0a
Compare
abhay
reviewed
Oct 27, 2022
abhay
reviewed
Oct 27, 2022
Co-authored-by: Abhay Kumar <75+abhay@users.noreply.github.com>
Vagabond
reviewed
Oct 28, 2022
Vagabond
reviewed
Oct 28, 2022
madninja
approved these changes
Oct 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds exponential backoff to reconnects to validators. The reconnects will start at 5 sec intervals and with each attempt expodentially increase up to a max of 180 secs. Reconnects include jitter