Skip to content
This repository was archived by the owner on Jun 12, 2023. It is now read-only.

use correct monitor ref #1725

Merged
merged 1 commit into from
Jun 8, 2022
Merged

use correct monitor ref #1725

merged 1 commit into from
Jun 8, 2022

Conversation

andymck
Copy link
Contributor

@andymck andymck commented Jun 8, 2022

Fixes incorrect use of the stream connection monitor var name from the state. Connection monitor var is defined in state here:
https://github.com/helium/miner/blob/master/src/poc/grpc_client_stream_custom.erl#L73

Set here:

https://github.com/helium/miner/blob/master/src/poc/grpc_client_stream_custom.erl#L140

But the DOWN info handler was stupidly looking for conn_mon rather than conn_monitor_ref

Thanks to community member nmc for supplying logs highlighting the issue

@andymck andymck changed the title use correct state var name use correct monitor ref Jun 8, 2022
@madninja madninja merged commit 992fb1a into master Jun 8, 2022
@madninja madninja deleted the andymck/fix-grpc-monitor-ref branch June 8, 2022 12:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants