This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
Add support for hip17 #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #677 +/- ##
==========================================
+ Coverage 68.69% 68.93% +0.24%
==========================================
Files 94 95 +1
Lines 12409 12665 +256
==========================================
+ Hits 8524 8731 +207
- Misses 3885 3934 +49
Continue to review full report at Codecov.
|
vihu
force-pushed
the
rg/hip0017
branch
4 times, most recently
from
7542e58
to
5049ba0
Compare
Vagabond
reviewed
Nov 17, 2020
Vagabond
reviewed
Nov 17, 2020
Vagabond
reviewed
Nov 17, 2020
|
I think we should merge the h3dex branch into this and then rewrite this code to use that rather than the active_gateways thing. |
Vagabond
reviewed
Nov 23, 2020
Vagabond
reviewed
Nov 24, 2020
vihu
force-pushed
the
rg/hip0017
branch
2 times, most recently
from
baafda2
to
db4d126
Compare
jadeallenx
reviewed
Dec 4, 2020
- Calculate hex densities - Add test for calculated hex densities on ledger pinned at 587624 - Add scale_test and specs - Add scale function for density - Add scale_test - Remove unnecessary hip17 chain vars - Plug HIP17 calculations to reward txn - Introduce yet another chain var for density_target_res - Add scale for rx and tx rewards
- Don't use active_gateways, use a fold - Use tested h3 keying scheme - Fix some other minor issues - Fix scale test - Switch to using h3dex for density map - More efficent initialization of densities - Remove nested loops - Fix eunits to use updated reward fun - Fix one more broken eunit and specs - Fix seek tuple and allow +1 upper bound - Add a simple known h3dex test - Review comment: Verbose spec for densities - Fix broken hip17 var validation
- Case ladder for hip17 vars - Bootstrap hexes for tests - Fix init_per_testcase for comparison test - Enhance tests, fix some more reward txn bugs - Add export scale test - Add basic real-world perf test for rewards - Dont build the full density map - Add a temporary full cross verification test - Fix scaling - Refactor hex API, make dialyzer happy - Adhere to update hex API in tests
- Start at k-ring of 2 - Fix exporting scale test data - Cleanup now unneeded debugging - Update limit function - Define lower resolution bound for rewards - Use chain var for lower bound res - Update scale_test to actually do cross checking - Update hip17 reward suite to run again
- Fix hex test suite - Fix interactive filtering
- Fix log msg - Add another crosscheck
evanmcc
reviewed
Dec 7, 2020
evanmcc
reviewed
Dec 7, 2020
evanmcc
reviewed
Dec 7, 2020
evanmcc
reviewed
Dec 7, 2020
| %% Calculate clipped and unclipped densities | ||
| densities(H3Index, VarMap, Interactive, Ledger). | ||
|
|
||
| -spec densities( |
There was a problem hiding this comment.
how hard would it be to make it so there's a precalc densities vs. on demand runtime switch so we could bench them against each other?
There was a problem hiding this comment.
My concern was the total memory needed for a global map. Even this local map building, I think, can throw away more than it does right now by discarding higher resolution hexes once we've calculated the lower resolution densities.
evanmcc
reviewed
Dec 9, 2020
| case blockchain_hex:var_map(Ledger) of | ||
| {error, _} -> | ||
| %% do the old thing | ||
| get_rewards_for_epoch(Current+1, End, Chain, Vars, Ledger, |
There was a problem hiding this comment.
why not just one of these with
VarMap = case blockchain_hex:var_map(Ledger) of {ok, VM} -> VM; _ -> #{} end,above it? Are we actually doing anything different?
There was a problem hiding this comment.
Planning to go through this today and see what we can do to make this suck less.
evanmcc
reviewed
Dec 9, 2020
HIP17 reward testing rework
Vagabond
reviewed
Dec 9, 2020
Vagabond
reviewed
Dec 9, 2020
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer: https://github.com/helium/HIP/blob/master/0017-hex-density-based-transmit-reward-scaling.md
TODO:
last_poc_challenge